From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Yury Norov <ynorov@nvidia.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
Sunil Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Kuniyuki Iwashima <kuniyu@google.com>,
Christian Brauner <brauner@kernel.org>,
Yajun Deng <yajun.deng@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH 2/2] net-sysfs: switch xps_queue_show() to sysfs_emit()
Date: Tue, 3 Mar 2026 20:16:51 +0100 [thread overview]
Message-ID: <276dd7af-17cf-4310-b77b-edea398c8a0e@t-8ch.de> (raw)
In-Reply-To: <20260303185507.111841-3-ynorov@nvidia.com>
On 2026-03-03 13:55:06-0500, Yury Norov wrote:
> Switch the function to use the proper sysfs_emit("%pb").
>
> Suggested-by: Thomas Weißschuh <linux@weissschuh.net>
> Signed-off-by: Yury Norov <ynorov@nvidia.com>
Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> net/core/net-sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index 07624b682b08..a260f8b4d5c6 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -1754,7 +1754,7 @@ static ssize_t xps_queue_show(struct net_device *dev, unsigned int index,
> out_no_maps:
> rcu_read_unlock();
>
> - len = bitmap_print_to_pagebuf(false, buf, mask, nr_ids);
> + len = sysfs_emit(buf, "%*pb\n", nr_ids, mask);
> bitmap_free(mask);
>
> return len < PAGE_SIZE ? len : -EINVAL;
next prev parent reply other threads:[~2026-03-03 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 18:55 [PATCH RESEND 0/2] net: cleanup bitmaps printing Yury Norov
2026-03-03 18:55 ` [PATCH 1/2] octeontx2-af: siplify rvu_debugfs Yury Norov
2026-03-05 10:16 ` [1/2] " Simon Horman
2026-03-05 14:55 ` [PATCH 1/2] " Jakub Kicinski
2026-03-03 18:55 ` [PATCH 2/2] net-sysfs: switch xps_queue_show() to sysfs_emit() Yury Norov
2026-03-03 19:16 ` Thomas Weißschuh [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 20:17 [PATCH v2 0/2] net: cleanup bitmaps printing Yury Norov
2026-03-19 20:17 ` [PATCH 2/2] net-sysfs: switch xps_queue_show() to sysfs_emit() Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=276dd7af-17cf-4310-b77b-edea398c8a0e@t-8ch.de \
--to=linux@weissschuh.net \
--cc=andrew+netdev@lunn.ch \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=horms@kernel.org \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sdf@fomichev.me \
--cc=sgoutham@marvell.com \
--cc=yajun.deng@linux.dev \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox