From: Paolo Abeni <pabeni@redhat.com>
To: Raju Rangoju <Raju.Rangoju@amd.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kuba@kernel.org,
edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch,
Thomas.Lendacky@amd.com, maxime.chevallier@bootlin.com
Subject: Re: [PATCH net] amd-xgbe: synchronize KR training with device operations
Date: Tue, 17 Mar 2026 13:09:41 +0100 [thread overview]
Message-ID: <27b77086-4f08-4d97-bc7a-2b5a4754a5af@redhat.com> (raw)
In-Reply-To: <20260313134210.3824872-1-Raju.Rangoju@amd.com>
On 3/13/26 2:42 PM, Raju Rangoju wrote:
> @@ -2115,7 +2160,9 @@ static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata,
> XP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, COMMAND, cmd);
> XP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, sub_cmd);
>
> - /* Issue the command */
> + /* Acquire mailbox lock for firmware command */
> + guard(mutex)(&pdata->mailbox_lock);
Also note that Documentation/process/maintainer-netdev.rst states:
Use of ``guard()`` is discouraged within any function longer than 20 lines,
``scoped_guard()`` is considered more readable. Using normal lock/unlock is
still (weakly) preferred.
/P
prev parent reply other threads:[~2026-03-17 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 13:42 [PATCH net] amd-xgbe: synchronize KR training with device operations Raju Rangoju
2026-03-17 12:08 ` [net] " Paolo Abeni
2026-03-17 12:09 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27b77086-4f08-4d97-bc7a-2b5a4754a5af@redhat.com \
--to=pabeni@redhat.com \
--cc=Raju.Rangoju@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox