From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB11C43381 for ; Sat, 16 Feb 2019 19:12:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02DFF21A4C for ; Sat, 16 Feb 2019 19:12:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HUeM3Dwx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732489AbfBPTMF (ORCPT ); Sat, 16 Feb 2019 14:12:05 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38320 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732474AbfBPTMF (ORCPT ); Sat, 16 Feb 2019 14:12:05 -0500 Received: by mail-wr1-f67.google.com with SMTP id v13so13775180wrw.5 for ; Sat, 16 Feb 2019 11:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vAwMhyZMGPN4gZn9BXWpXz4xYU6RPNwhHnnQ1EXasTM=; b=HUeM3Dwxq12E7hsGoJNPjuZYA4WRW3uToHz7WVzR0InJrR2nj8Nql9TAd69yJ4PH9Y JLVZOURSB7iMtBqWPAyfR3dLXPC60Ys2eSoMyg8v+XMQj0AAuAmuLLjMA9Pk/VavdJ+5 ZVLa8a1oA51sJzq7myFwTlJ+dJYQs4V0wzv3w1a0gayTO1s3umvaAhuMciEhtKj4zkCm d4pMPqZiaegr4Lpl8UPL7c+fmyTMS+Itym8LkMnVYvIBqPUfIuZlDF5cXFwINBgs8vuD oVt7ympU+OZNtthadwiaSiTRAfHerhvXH3Vycwbkr0p6llOlyz9i7YBUc7oU3O9lzKIs SJUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vAwMhyZMGPN4gZn9BXWpXz4xYU6RPNwhHnnQ1EXasTM=; b=JAGV/wl202cjJOGtE92Xa9NBilDBNOVZDOG7KwR8KG1roDjX7jg5WBPC5HRRng6FJ0 JBIi3KiVuBHzD3ESPaSLB2i69SdGHHB8xuIYYZR3xKGefACic3o94ksbAe83Cv5RKP8k FECeFn7C6sEiGH3DflCA1sqMlp8wQkx1QE3L76fzoc9SUdREbl5ghN2at/ST1vknJwVf nPhceSpqBxcPBmXlo8Qr1ZSwtjvXCWVZb3FDOeF0mYgRT23d/ISXTMHOztzy2B1QhekV d14MUId+NhbrFqaGQysVAAEIJFIOroqT/gprMKmatFyxVrcqLux3wpL2VpoN3fM30ZfC M4YQ== X-Gm-Message-State: AHQUAubD5fUH47ldBqxZoaEdhP6XWJ0SoChSJxTuqALQl9s44Lt04XMi w5IdjLntCVZyoxww+C/7/7YcAzU9 X-Google-Smtp-Source: AHgI3IbvppjK53y3NTGddNhGNRLClL1nM0ANKn4r2M61sCne3iKWRlN+eEj2ID1B/9iUB7TUNQWkxA== X-Received: by 2002:a5d:6288:: with SMTP id k8mr11817816wru.173.1550344323530; Sat, 16 Feb 2019 11:12:03 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:fc50:d076:bfa9:dffa? (p200300EA8BF1E200FC50D076BFA9DFFA.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:fc50:d076:bfa9:dffa]) by smtp.googlemail.com with ESMTPSA id t3sm1921779wmc.20.2019.02.16.11.12.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 11:12:02 -0800 (PST) Subject: [PATCH net-next 1/2] net: phy: disable aneg in genphy_c45_pma_setup_forced From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller , Russell King - ARM Linux Cc: "netdev@vger.kernel.org" References: <8945c224-bfff-294d-f855-979016e077ec@gmail.com> Message-ID: <27bb134f-eb4e-e43a-5d9d-2c551a22428c@gmail.com> Date: Sat, 16 Feb 2019 20:10:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <8945c224-bfff-294d-f855-979016e077ec@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When genphy_c45_pma_setup_forced() is called the "aneg enabled" bit may still be set, therefore clear it. This is also in line with what genphy_setup_forced() does for Clause 22. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-c45.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index bef126344..0374c50b1 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -71,6 +71,10 @@ int genphy_c45_pma_setup_forced(struct phy_device *phydev) return ret; return phy_write_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL2, ctrl2); + if (ret < 0) + return ret; + + return genphy_c45_an_disable_aneg(phydev); } EXPORT_SYMBOL_GPL(genphy_c45_pma_setup_forced); -- 2.20.1