From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8557113C9C4; Mon, 20 Apr 2026 05:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776664276; cv=none; b=qAHfarpKSPW4mewekYYrPry1dQOnBxLqWOdZU3c5YBfnX8HgJBaQb54uCOwhiwXdtPNXPEsQF8Z0/gBpmMz2eAke9SssbeKOR5h8sNtSFwya32u99Bi/rNq5grROuPqY+YvrzVe1G8Z0zoB6uqcw16f6SYtc/2InJi3cFck4188= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776664276; c=relaxed/simple; bh=mM7nrILypJTY/P85KRkTSJEidfXBiMKGe3fl6hBpgDo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Z2bhApxKqfO7r69nLC6Ir3iG6jBCA1vC8F+Z1bET8B9AEqqjzy4gU3D251w25i8r/RKRC1Hula/wZTjkl1+FIsMk0DP8yzqD2/2uGtqujhl2jA8j8u/bLx79HEEmMbUflRbHsSgn3I2i24blpISncYXnWYTIocYr1kFJoVo2vT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=RUr0v7VJ; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="RUr0v7VJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1776663668; bh=mM7nrILypJTY/P85KRkTSJEidfXBiMKGe3fl6hBpgDo=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=RUr0v7VJXDXoYgkx7NeicB35aKbqQvj9LNIyZvRG9rXeOvSsxd69YogVaEt5ZhDuU xs0WftUvmsDUMFDDtfHiR0FSbgtzRXHUM5LtAOXvKyouqdSU4o92GMnVbALnOq29Pa e3DsTrQKpYipTlsoiS/8fkLqk4RurZ0/8Tl220/o6Oj9DMJcwsnAXufnGhuHnjbGNY RCgA5TSbuULu/Kq++em+gb+xu80thZcR440tb0zQZCtGdMD1iRl0Q6If/t67VHdMbd +oSLU/ntWeg629g9DXlFc4Y8P/x5kiaUTK7YTw05SorAVHCH1+QAdpAOh6rbbMCQ+x kb0M+R25trwIQ== Received: from [192.168.72.167] (210-10-213-150.per.static-ipl.aapt.com.au [210.10.213.150]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 9FC4260C8D; Mon, 20 Apr 2026 13:41:07 +0800 (AWST) Message-ID: <28119a94e183d695389f51282d48580adc7703b4.camel@codeconstruct.com.au> Subject: Re: [PATCH net] net: mctp: fix don't require received header reserved bits to be zero From: Jeremy Kerr To: wit_yuan Cc: yuanzm2@lenovo.com, matt@codeconstruct.com.au, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Mon, 20 Apr 2026 13:41:07 +0800 In-Reply-To: <20260417141340.5306-1-yuanzhaoming901030@126.com> References: <20260417141340.5306-1-yuanzhaoming901030@126.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2+deb12u1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, > From the MCTP Base specification (DSP0236 v1.2.1), the first byte of > the MCTP header contains a 4 bit reserved field, and 4 bit version. >=20 > On our current receive path, we require those 4 reserved bits to be > zero, but the 9500-8i card is non-conformant, and may set these > reserved bits. >=20 > DSP0236 states that the reserved bits must be written as zero, and > ignored when read. While the device might not conform to the former, > we should accept these message to conform to the latter. >=20 > Relax our check on the MCTP version byte to allow non-zero bits in the > reserved field. >=20 > Fixes: 889b7da23abf ("mctp: Add initial routing framework") > Signed-off-by: Yuan Zhaoming Looks good, thanks for the contribution! Acked-by: Jeremy Kerr Cheers, Jeremy