From: Menglong Dong <menglong.dong@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Menglong Dong <menglong8.dong@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
jiang.biao@linux.dev, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v8 04/11] bpf: support fsession for bpf_session_is_return
Date: Sat, 10 Jan 2026 14:16:35 +0800 [thread overview]
Message-ID: <2813099.mvXUDI8C0e@7950hx> (raw)
In-Reply-To: <CAADnVQJTc3qegim-hyzaurnCX-8pRQWoj+r9+0jgBQ-WmpLHuw@mail.gmail.com>
On 2026/1/10 14:05, Alexei Starovoitov wrote:
> On Fri, Jan 9, 2026 at 7:38 PM Menglong Dong <menglong.dong@linux.dev> wrote:
> >
> >
> > >
> > > Remove the first hunk and make the 2nd a comment instead of a real function?
> >
> > Agree. So it will be:
> >
> > +static bool bpf_fsession_is_return(void *ctx)
> > +{
> > + /* This helper call is implemented and inlined by the verifier, and the logic is:
> > + * return !!(((u64 *)ctx)[-1] & (1 << BPF_TRAMP_M_IS_RETURN));
> > + */
> > + return false;
> > +}
>
> No need to define an empty function.
> A comment next to 'inline-by-bpf-asm' part explaining what is going on
> will be enough.
Yeah, I see. I'll remove the whole part, and do some comment
in the verifier where I inline this function instead.
Thanks!
Menglong Dong
>
next prev parent reply other threads:[~2026-01-10 6:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 2:24 [PATCH bpf-next v8 00/11] bpf: fsession support Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 01/11] bpf: add " Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 02/11] bpf: use last 8-bits for the nr_args in trampoline Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 03/11] bpf: change prototype of bpf_session_{cookie,is_return} Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 04/11] bpf: support fsession for bpf_session_is_return Menglong Dong
2026-01-10 2:40 ` Alexei Starovoitov
2026-01-10 3:37 ` Menglong Dong
2026-01-10 4:04 ` Menglong Dong
2026-01-10 6:05 ` Alexei Starovoitov
2026-01-10 6:16 ` Menglong Dong [this message]
2026-01-08 2:24 ` [PATCH bpf-next v8 05/11] bpf: support fsession for bpf_session_cookie Menglong Dong
2026-01-10 2:42 ` Alexei Starovoitov
2026-01-10 3:38 ` Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 06/11] bpf,x86: introduce emit_st_r0_imm64() for trampoline Menglong Dong
2026-01-10 2:45 ` Alexei Starovoitov
2026-01-10 3:40 ` Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 07/11] bpf,x86: add fsession support for x86_64 Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 08/11] libbpf: add fsession support Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 09/11] selftests/bpf: add testcases for fsession Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 10/11] selftests/bpf: add testcases for fsession cookie Menglong Dong
2026-01-08 2:24 ` [PATCH bpf-next v8 11/11] selftests/bpf: test fsession mixed with fentry and fexit Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2813099.mvXUDI8C0e@7950hx \
--to=menglong.dong@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hpa@zytor.com \
--cc=jiang.biao@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox