From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC967258CE7 for ; Sat, 10 Jan 2026 06:17:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768025835; cv=none; b=Qs84s2YhxwvudGQRQOtdbeKcR0VtrXeSqKP2q5lJ5J3hRPOc2kMv8z/FU7SyZ6Sxn9tG/t6aGP9eKrtOI/+7BPq4zEXdRRuJvZxJtszCdx5oEUX8GFK941UWh926j00jBsxvbGu8qMa+suerrUdiXv0hvBfQwW6tzIQuA80T798= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768025835; c=relaxed/simple; bh=vOplLJEX9isv42WotdBVOkJgDNihHfjDD0O3L5H/tMY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jbKEBpHkAKkfJq3PgukdbbrCQroEEiQFWgTxedD8qf8zL4YGZkWCqhj1yWkjtrtBY1zIvJbOehjj4rP8bqER1uzeBluaaukm81/vJ9XrF0OTx40hvJ48iKd+1YanlvaLNO6sr9ys1A5tiWm02tIOgkHe8/l0fzvjaf32CVA4i6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=R8AMfDgq; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="R8AMfDgq" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768025821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UJEhCFHRTbkOHjEzYSkqsIGSyEYidG74DyThTLA/jbs=; b=R8AMfDgqbes+l+8+nfCFf0uaorNU4r8p6SPeRm03Dinj8AewFOMkHKwj8ajbBFqNBtapoR UoBXgDBCwoOB/2RO9mXh09X7quIcO4YPVHzDMxckib+ym3ULowBhA0UXXz4LQivPrnC80H hQV2AVPm6A1h23I3WI7FQdRYSd2H69k= From: Menglong Dong To: Alexei Starovoitov Cc: Menglong Dong , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Martin KaFai Lau , Eduard , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "David S. Miller" , David Ahern , Thomas Gleixner , Ingo Molnar , jiang.biao@linux.dev, Borislav Petkov , Dave Hansen , X86 ML , "H. Peter Anvin" , bpf , Network Development , LKML Subject: Re: [PATCH bpf-next v8 04/11] bpf: support fsession for bpf_session_is_return Date: Sat, 10 Jan 2026 14:16:35 +0800 Message-ID: <2813099.mvXUDI8C0e@7950hx> In-Reply-To: References: <20260108022450.88086-1-dongml2@chinatelecom.cn> <5075208.31r3eYUQgx@7950hx> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Migadu-Flow: FLOW_OUT On 2026/1/10 14:05, Alexei Starovoitov wrote: > On Fri, Jan 9, 2026 at 7:38=E2=80=AFPM Menglong Dong wrote: > > > > > > > > > > Remove the first hunk and make the 2nd a comment instead of a real fu= nction? > > > > Agree. So it will be: > > > > +static bool bpf_fsession_is_return(void *ctx) > > +{ > > + /* This helper call is implemented and inlined by the verifier,= and the logic is: > > + * return !!(((u64 *)ctx)[-1] & (1 << BPF_TRAMP_M_IS_RETURN)= ); > > + */ > > + return false; > > +} >=20 > No need to define an empty function. > A comment next to 'inline-by-bpf-asm' part explaining what is going on > will be enough. Yeah, I see. I'll remove the whole part, and do some comment in the verifier where I inline this function instead. Thanks! Menglong Dong >=20