From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next] net: mscc: allow extracting the FCS into the skb Date: Wed, 10 Oct 2018 09:25:01 -0700 Message-ID: <28179B83-2C71-47FA-9D9C-49237E4A07AE@gmail.com> References: <20181001095714.26024-1-antoine.tenart@bootlin.com> <25a88126-2397-a1fb-0c0d-06504bb348ca@gmail.com> <20181002065937.GB3368@kwain> <20181002124323.GC9155@lunn.ch> <20181010144631.GE3368@kwain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com, quentin.schulz@bootlin.com, allan.nielsen@microchip.com To: Antoine Tenart , Andrew Lunn Return-path: In-Reply-To: <20181010144631.GE3368@kwain> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On October 10, 2018 7:46:31 AM PDT, Antoine Tenart wrote: >Hi all, > >On Tue, Oct 02, 2018 at 02:43:23PM +0200, Andrew Lunn wrote: >> > The question could be "do we need len +=3D ETH_FCS_LEN" to account >for the >> > FCS when NETIF_F_RXFCS is used", but I looked at other drivers and >it >> > seemed to me the FCS is not accounted in the stats=2E Should it be? >>=20 >> There does not appear to be a good answer to that=2E I submitted a >patch >> to a driver i'm using to not count it, so that the stats counters we >> consistent with another driver=2E The patch was rejected=2E >>=20 >> I think the best you can do is flip a coin, and then document it >using >> a comment about if it is/is not included=2E > >I'll leave it as-is then :) > >@Dave, Florian: it seems to me no modification was requested after >discussing those changes=2E Where do we stand regarding the patch? Silence means agreement, thanks for your explanation, no more questions or= concerns on my side=2E --=20 Florian