From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Soltys <soltys@ziu.info>
Subject: Re: [PATCH next] bonding: pass link-local packets to bonding master
 also.
Date: Wed, 18 Jul 2018 00:17:10 +0200
Message-ID: <281b302f-d670-a6fb-f34b-0c3df9e7dec6@ziu.info>
References: <20180716011246.225647-1-mahesh@bandewar.net>
 <12404.1531776273@nyx>
 <CAF2d9jgFEn2POF0L-ZXAwgtC_mqbni8ir9zT7EvrbxLd6CSQpg@mail.gmail.com>
 <1e7bc087-06e7-e3e1-aae2-2169a0170189@ziu.info>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Mahesh Bandewar <mahesh@bandewar.net>,
        Andy Gospodarek <andy@greyhouse.net>,
        Veaceslav Falico <vfalico@gmail.com>,
        David Miller <davem@davemloft.net>,
        Netdev <netdev@vger.kernel.org>,
        Stephen Hemminger <stephen@networkplumber.org>
To: =?UTF-8?B?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS1?=
         =?UTF-8?B?4KS+4KSwKQ==?= <maheshb@google.com>,
        Jay Vosburgh <jay.vosburgh@canonical.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from drutsystem.com ([84.10.39.251]:41398 "EHLO drutsystem.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1730092AbeGQWwD (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 17 Jul 2018 18:52:03 -0400
In-Reply-To: <1e7bc087-06e7-e3e1-aae2-2169a0170189@ziu.info>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2018-07-17 11:32, Michal Soltys wrote:
> On 07/17/2018 01:53 AM, Mahesh Bandewar (महेश बंडेवार) wrote:
>> On Mon, Jul 16, 2018 at 2:24 PM, Jay Vosburgh
>> <jay.vosburgh@canonical.com> wrote:
>>> Mahesh Bandewar <mahesh@bandewar.net> wrote:
>>>
>>>> From: Mahesh Bandewar <maheshb@google.com>
>>>>
>>>> Commit b89f04c61efe ("bonding: deliver link-local packets with
>>>> skb->dev set to link that packets arrived on") changed the behavior
>>>> of how link-local-multicast packets are processed. The change in
>>>> the behavior broke some legacy use cases where these packets are
>>>> expected to arrive on bonding master device also.
>>>>
>>>> This patch passes the packet to the stack with the link it arrived
>>>> on as well as passes to the bonding-master device to preserve the
>>>> legacy use case.
>>>
>>>          Michal, can you test this?  I'm travelling this week and won't
>>> be able to run the patch.
> 
> 
> Yes, will test today and report.
> 

The patch looks to be working fine - tested both passive bridge
(stp_state == 0) and with in-kernel implementation active (stp_state ==
1). No loops, no issues so far.