From: David Ahern <dsahern@gmail.com>
To: Colin King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
Robert Shearman <rshearma@brocade.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Amine Kherbouche <amine.kherbouche@6wind.com>
Subject: Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static
Date: Wed, 11 Oct 2017 08:12:34 -0600 [thread overview]
Message-ID: <282bd0a3-4cf6-4269-c07f-a476aa0bb764@gmail.com> (raw)
In-Reply-To: <20171011095328.17546-1-colin.king@canonical.com>
On 10/11/17 3:53 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function ipgre_mpls_encap_hlen is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'ipgre_mpls_encap_hlen' was not declared. Should it be static?
>
Fixes: bdc476413dcdb ("ip_tunnel: add mpls over gre support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/mpls/af_mpls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
> index 9745e8f69810..8ca9915befc8 100644
> --- a/net/mpls/af_mpls.c
> +++ b/net/mpls/af_mpls.c
> @@ -41,7 +41,7 @@ static int label_limit = (1 << 20) - 1;
> static int ttl_max = 255;
>
> #if IS_ENABLED(CONFIG_NET_IP_TUNNEL)
> -size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e)
> +static size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e)
> {
> return sizeof(struct mpls_shim_hdr);
> }
>
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2017-10-11 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 9:53 [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static Colin King
2017-10-11 14:12 ` David Ahern [this message]
2017-10-12 3:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=282bd0a3-4cf6-4269-c07f-a476aa0bb764@gmail.com \
--to=dsahern@gmail.com \
--cc=amine.kherbouche@6wind.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).