From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower Date: Thu, 26 Oct 2017 14:35:41 -0700 Message-ID: <28335085-cc51-85a5-d602-4ae9d1e1088c@oracle.com> References: <150768099999.5320.1633617713417675266.stgit@anamdev.jf.intel.com> <150768148418.5320.6338243543224569414.stgit@anamdev.jf.intel.com> <86d2bf80-cf02-9cc0-291d-c00ff39d613b@oracle.com> <888ad716-75c7-f1c0-439a-58fdeb9a7234@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: "Nambiar, Amritha" , intel-wired-lan@osuosl.org Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:49076 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932369AbdJZVfz (ORCPT ); Thu, 26 Oct 2017 17:35:55 -0400 In-Reply-To: <888ad716-75c7-f1c0-439a-58fdeb9a7234@intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/26/2017 2:29 PM, Nambiar, Amritha wrote: > On 10/11/2017 4:30 PM, Shannon Nelson wrote: >> On 10/10/2017 5:24 PM, Amritha Nambiar wrote: [...] >>> + /* For Geneve, the VNI should be placed in offset shifted by a >>> + * byte than the offset for the Tenant ID for rest of the >> >> This comment isn't quite clear - maybe s/than/then/ ? > > How about, "For Geneve, the VNI should begin at an offset shifted by a > byte compared to the offset normally used for the Tenant ID for other > tunnel types" ? Or maybe "Due to hardware eccentricities, the VNI for Geneve is shifted one more byte further than normally used for Tenant ID in other tunnel types" [...] >>> + dev_err(&pf->pdev->dev, "Bad src port mask 0x%04x\n", >> >> Consider using %pI4 > > For ports, I'll keep the 0x%04x. I'll change to %pI4 for the IPv4 > address masks. Oh, right, that one's a port. sln