From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3B3C43381 for ; Fri, 15 Feb 2019 01:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 725D721934 for ; Fri, 15 Feb 2019 01:41:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UOXfLjx0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730905AbfBOBlf (ORCPT ); Thu, 14 Feb 2019 20:41:35 -0500 Received: from mail-yb1-f176.google.com ([209.85.219.176]:34780 "EHLO mail-yb1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727593AbfBOBle (ORCPT ); Thu, 14 Feb 2019 20:41:34 -0500 Received: by mail-yb1-f176.google.com with SMTP id j62so3221659ybb.1 for ; Thu, 14 Feb 2019 17:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Y+OZvStOFGNcA9UNHISyLSOuSiVA7oA7kF20H71Memk=; b=UOXfLjx0Gb3ePlG+U+aqGHdP6iBAc1XxtlZcLQwg3U8ZzbQdnn/HmytR3CWe1Efowb sukJOtY4cbTCpZFpLeVR9L8iX7Sc+UYuDYAcqIvBNHLCQ59SwTp9XkhncPpJJZLKzDPZ O+PFPKjjfFnQ5H4jOQVxvGVcHICU1kb7H0HTWzKFSsLdbuoYwoFu06BUNpinUGZrn12S 2tdmqLsXp2FHF8Y/0+2MPUvPpyxmU6V7N2TU6/n54zqBkC2UBMm0Ytm1x94nf68Y6LDQ EZeuGnZKx/rE2fibyGzLsVb49e+YvGhblPhA6n2Hfh8TOb0RwzwYVj8okxmF0Vww+93A wmxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y+OZvStOFGNcA9UNHISyLSOuSiVA7oA7kF20H71Memk=; b=AwyBOm8GIyXUCfwJAdd3zcYuhlC6cbRLbsxRfFuIFIZnD8cXssDqg8/qbAYO+6CiAs Q/eiQLDqyGPjzj2H9zN9+91CwCzd73lzTWqygJYfEZPnMpRmZ+b3CnPtiuFqx6hiNO9l KiwkCs60EoTCJw2hseTa99mEqMta6Pqg1RQjjLcE6ZV5sGF2H0ZZ5C8VaBnpuHjZxeLJ CAqt+jd831CViF0mIJjH63h9sS2hK28kzAwN9SDbZHUGS35TC7qrXBNKYi5p1lcsgeH5 6E6KFQHIbDZVrcdQgH3Aqojw7E/8tZKMIscgeoF11/sFrf3brd6dmLh4hLEapXKNqmUM lmCw== X-Gm-Message-State: AHQUAuYRsOurYEBnTYDpzFzb8SJyUH2bIhRlTqLyDUaXN2lYjtKlQ9uQ rOFBDm7KHG4OX3oYeU+TnmM= X-Google-Smtp-Source: AHgI3IavmEXkkCB5j7fE2iotPfcwQSjShA7gU4O2SJGrJdJWiYCfrY98RlHJAQb1SWIsXJLBTuSSNg== X-Received: by 2002:a25:c7d1:: with SMTP id w200mr738375ybe.498.1550194893884; Thu, 14 Feb 2019 17:41:33 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id r124sm1387006ywb.39.2019.02.14.17.41.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 17:41:32 -0800 (PST) Subject: Re: (2) (2) [Bug reporting] kernel panic during handle the dst unreach icmp msg. To: soukjin.bae@samsung.com, "netdev@vger.kernel.org" Cc: =?UTF-8?B?67CV7KKF7Ja4?= , Yuchung Cheng References: <20190214074641epcms1p1db1c5589f96718a440a166328eec9ebd@epcms1p1> <20190214235427epcms1p25712530506811b6279ffbe6c54914e72@epcms1p2> <4989ee5d-0de3-b7a7-494d-f0c133dfc465@gmail.com> <20190215013753epcms1p4249f1b2b67f8e706618f62cb7bd76412@epcms1p4> From: Eric Dumazet Message-ID: <28510ff2-bc73-52ed-cde5-25c97c73238a@gmail.com> Date: Thu, 14 Feb 2019 17:41:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190215013753epcms1p4249f1b2b67f8e706618f62cb7bd76412@epcms1p4> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/14/2019 05:37 PM, 배석진 wrote: >> The current code checks if icsk->icsk_backoff is not zero, so it looks like we have to move >> some code like this. >> >> It looks a silly bug to have no packet in write/rtx queues, and a non zero icsk_backoff. >> >> >> >> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c >> index 2079145a3b7c5f498af429c9a8289342e4421fca..cf3c5095c10e8e7e56621beae2f93c93de184489 100644 >> --- a/net/ipv4/tcp.c >> +++ b/net/ipv4/tcp.c >> @@ -2528,6 +2528,7 @@ void tcp_write_queue_purge(struct sock *sk) >> sk_mem_reclaim(sk); >> tcp_clear_all_retrans_hints(tcp_sk(sk)); >> tcp_sk(sk)->packets_out = 0; >> + inet_csk(sk)->icsk_backoff = 0; >> } >> >> int tcp_disconnect(struct sock *sk, int flags) >> @@ -2576,7 +2577,6 @@ int tcp_disconnect(struct sock *sk, int flags) >> tp->write_seq += tp->max_window + 2; >> if (tp->write_seq == 0) >> tp->write_seq = 1; >> - icsk->icsk_backoff = 0; >> tp->snd_cwnd = 2; >> icsk->icsk_probes_out = 0; >> tp->snd_ssthresh = TCP_INFINITE_SSTHRESH; >> > > yes right, queue problems. > I don't know about icsk_backoff :p > this will be work. thanks! > I am running our packetdrill tests just to be reasonably safe.