From: Eric Dumazet <eric.dumazet@gmail.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Vlad Buslov <vladbu@mellanox.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer
Date: Mon, 9 Jul 2018 13:51:41 -0700 [thread overview]
Message-ID: <2859e5ba-7d4f-a5eb-1360-979c09b7f71c@gmail.com> (raw)
In-Reply-To: <20180709203415.GB10923@localhost.localdomain>
On 07/09/2018 01:34 PM, Marcelo Ricardo Leitner wrote:
> I am not sure if this is enough to fix the entire issue. Now it will
> fetch the length correctly but, what guarantees that when it tries to
> actually copy the key (tcf_action_dump_1), the same act_cookie pointer
> will be used? As in, can't the new re-fetch be different/smaller than
> the object used here?
>
Yes, this presumably should use rtnl_dereference()
RTNL should be held between tcf_action_shared_attrs_size() and tcf_action_dump_1()
Although it might not be the case anymore, we keep changing this RTNL requirement
in dump operations ;)
next prev parent reply other threads:[~2018-07-09 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 17:26 [PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer Vlad Buslov
2018-07-09 20:34 ` Marcelo Ricardo Leitner
2018-07-09 20:44 ` Vlad Buslov
2018-07-12 2:29 ` Marcelo Ricardo Leitner
2018-07-09 20:51 ` Eric Dumazet [this message]
2018-07-12 6:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2859e5ba-7d4f-a5eb-1360-979c09b7f71c@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).