Re: [PATCH net-next v4 3/4] net: bonding: send peer notify when failure recovery

Nikolay Aleksandrov
2025-05-14T09:39:14Z

On 5/14/25 12:25, Tonghao Zhang wrote:
> After LACP protocol recovery, the port can transmit packets.
> However, if the bond port doesn't send gratuitous ARP/ND
> packets to the switch, the switch won't return packets through
> the current interface. This causes traffic imbalance. To resolve
> this issue, when LACP protocol recovers, send ARP/ND packets.
>
> Cc: Jay Vosburgh <jv@jvosburgh.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Simon Horman <horms@kernel.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> Signed-off-by: Tonghao Zhang <tonghao@bamaicloud.com>
> Signed-off-by: Zengbing Tu <tuzengbing@didiglobal.com>
> ---
> Documentation/networking/bonding.rst | 5 +++--
> drivers/net/bonding/bond_3ad.c | 13 +++++++++++++
> drivers/net/bonding/bond_main.c | 21 ++++++++++++++++-----
> 3 files changed, 32 insertions(+), 7 deletions(-)
>

rtnl is a bit heavy for updating a single variable, IMO
you should've refactored the code to protect it in a different way
(e.g. mode_lock or some other lighter type of sync primitive).

Anyway the patch does look good,
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>