From: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
To: b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH 03/12] batman-adv: add UNICAST_4ADDR packet type
Date: Wed, 07 Nov 2012 20:25:10 +0100 [thread overview]
Message-ID: <2868197.Rr5d6gvmpi@sven-desktop.home.narfation.org> (raw)
In-Reply-To: <1403033.aGBWZgaJ6z-1RWNDQYo44h8XcdJbWeDu3TFMtCCXL7YSoIsB4E12gc@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
On Wednesday 07 November 2012 20:17:08 Sven Eckelmann wrote:
> On Wednesday 07 November 2012 20:11:33 Antonio Quartulli wrote:
> > +/**
> > + * struct batadv_unicast_4addr_packet - extended unicast packet
> > + * @u: common unicast packet header
> > + * @src: address of the source
> > + * @subtype: packet subtype
> > + */
> > +struct batadv_unicast_4addr_packet {
> > + struct batadv_unicast_packet u;
> > + uint8_t src[ETH_ALEN];
> > + uint8_t subtype;
> > + uint8_t reserved;
> > + /* "4 bytes boundary + 2 bytes" long to make the payload after the
> > + * following ethernet header again 4 bytes boundary aligned
> > + */
> > +};
>
> This doesn't work as you think. Now you have 2 extra padding bytes at the
> end of the batadv_unicast_4addr_packet and therefore make the payload (IPv4
> header..) after the following ethernet header again wrongly aligned.
Sry, my fault. Mixed it up with another packed which had a __be32 included
(batadv_bcast_packet).
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-07 19:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 19:11 pull request: batman-adv 2012-11-07 Antonio Quartulli
2012-11-07 19:11 ` [PATCH 01/12] batman-adv: Reserve extra bytes in skb for better alignment Antonio Quartulli
2012-11-07 19:11 ` [PATCH 02/12] batman-adv: Mark correctly aligned headers not as __packed Antonio Quartulli
2012-11-07 19:11 ` [PATCH 03/12] batman-adv: add UNICAST_4ADDR packet type Antonio Quartulli
2012-11-07 19:17 ` [B.A.T.M.A.N.] " Sven Eckelmann
[not found] ` <1403033.aGBWZgaJ6z-1RWNDQYo44h8XcdJbWeDu3TFMtCCXL7YSoIsB4E12gc@public.gmane.org>
2012-11-07 19:25 ` Sven Eckelmann [this message]
2012-11-07 19:11 ` [PATCH 04/12] batman-adv: Distributed ARP Table - add a new debug log level Antonio Quartulli
2012-11-07 19:11 ` [PATCH 05/12] batman-adv: Distributed ARP Table - create DHT helper functions Antonio Quartulli
2012-11-07 19:11 ` [PATCH 06/12] batman-adv: Distributed ARP Table - implement local storage Antonio Quartulli
2012-11-07 19:11 ` [PATCH 07/12] batman-adv: Distributed ARP Table - add ARP parsing functions Antonio Quartulli
2012-11-07 19:11 ` [PATCH 08/12] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli
2012-11-07 19:11 ` [PATCH 09/12] batman-adv: Distributed ARP Table - add compile option Antonio Quartulli
2012-11-07 19:11 ` [PATCH 10/12] batman-adv: Distributed ARP Table - add runtime switch Antonio Quartulli
2012-11-07 19:11 ` [PATCH 11/12] batman-adv: Add get_ethtool_stats() support for DAT Antonio Quartulli
2012-11-07 19:11 ` [PATCH 12/12] batman-adv: enable fast client detection using unicast_4addr packets Antonio Quartulli
[not found] ` <1352315502-20324-1-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
2012-11-08 0:10 ` pull request: batman-adv 2012-11-07 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2868197.Rr5d6gvmpi@sven-desktop.home.narfation.org \
--to=sven-kadoipu9uxwei8dpzvb4nw@public.gmane.org \
--cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).