From: Paul Moore <paul@paul-moore.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] net/netlabel: copy and paste bug in netlbl_cfg_unlbl_map_add()
Date: Tue, 29 Nov 2011 12:47:54 -0500 [thread overview]
Message-ID: <2892320.ttUs8EtPs3@sifl> (raw)
In-Reply-To: <20111124071820.GB14122@elgon.mountain>
On Thursday, November 24, 2011 10:18:20 AM Dan Carpenter wrote:
> This was copy and pasted from the IPv4 code. We're calling the
> ip4 version of that function and map4 is NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
> index 8ed67dcc..3735297 100644
> --- a/net/netlabel/netlabel_kapi.c
> +++ b/net/netlabel/netlabel_kapi.c
> @@ -162,8 +162,8 @@ int netlbl_cfg_unlbl_map_add(const char *domain,
> map6->list.addr.s6_addr32[3] &= mask6->s6_addr32[3];
> map6->list.mask = *mask6;
> map6->list.valid = 1;
> - ret_val = netlbl_af4list_add(&map4->list,
> - &addrmap->list4);
> + ret_val = netlbl_af6list_add(&map6->list,
> + &addrmap->list6);
> if (ret_val != 0)
> goto cfg_unlbl_map_add_failure;
> break;
Thanks for fixing this. I actually stumbled across this just last week while
working on the CALIPSO stuff and queued up a patch but didn't get a chance to
verify it before Thanksgiving - you just saved me the effort :)
--
paul moore
www.paul-moore.com
prev parent reply other threads:[~2011-11-29 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 7:18 [patch] net/netlabel: copy and paste bug in netlbl_cfg_unlbl_map_add() Dan Carpenter
2011-11-25 6:42 ` David Miller
2011-11-29 17:47 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2892320.ttUs8EtPs3@sifl \
--to=paul@paul-moore.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox