From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next] bridge: mcast: Default back to multicast enabled state Date: Mon, 1 Oct 2018 12:07:57 +0300 Message-ID: <28da23ff-cda0-382d-dcf1-0d2bd8c56573@cumulusnetworks.com> References: <20181001085701.23295-1-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-wr1-f66.google.com ([209.85.221.66]:34459 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbeJAPop (ORCPT ); Mon, 1 Oct 2018 11:44:45 -0400 Received: by mail-wr1-f66.google.com with SMTP id z4-v6so11615621wrb.1 for ; Mon, 01 Oct 2018 02:07:59 -0700 (PDT) In-Reply-To: <20181001085701.23295-1-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 01/10/2018 11:57, Ido Schimmel wrote: > Commit 13cefad2f2c1 ("net: bridge: convert and rename mcast disabled") > converted the 'multicast_disabled' field to an option bit named > 'BROPT_MULTICAST_ENABLED'. > > While the old field was implicitly initialized to 0, the new field is > not initialized, resulting in the bridge defaulting to multicast > disabled state and breaking existing applications. > > Fix this by explicitly initializing the option. > > Fixes: 13cefad2f2c1 ("net: bridge: convert and rename mcast disabled") > Signed-off-by: Ido Schimmel > --- > net/bridge/br_multicast.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c > index 928024d8360d..024139b51d3a 100644 > --- a/net/bridge/br_multicast.c > +++ b/net/bridge/br_multicast.c > @@ -1976,6 +1976,7 @@ void br_multicast_init(struct net_bridge *br) > br->ip6_other_query.delay_time = 0; > br->ip6_querier.port = NULL; > #endif > + br_opt_toggle(br, BROPT_MULTICAST_ENABLED, true); > br_opt_toggle(br, BROPT_HAS_IPV6_ADDR, true); > > spin_lock_init(&br->multicast_lock); > Thanks, Acked-by: Nikolay Aleksandrov