From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29BA31A3033 for ; Wed, 11 Sep 2024 15:48:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726069687; cv=none; b=Uhb4tsCMA6LpoXxiZmILw3FYb4IljrKRfWlm3PM6Uni0b+Vq5pP6jn4joVewSSaInNFNANcbth1BzITa06uWEvquIA3tHv4pK+f+nLwERpv5xigaMeNKYDzlNvQaN1Be3fDPswhAPQYixXllBlBLB/f0rvy8UioxPjFmaZX83Mc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726069687; c=relaxed/simple; bh=fI3XQOxlFluHG72zXx7/N5FWclch0225esKChDMzphA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gqv0EEhjGeGOOeBUScjloC23YF6AkpB0ssS3LaEDx/N43PjaJrx7sDIz+PR68FRkqgGy3VG659MFyXRO4tHiHS7wEAODE28y3IMnZx+ijmnwCvW+wZBQOb931kLX15NF5HePoG1WUFPG1JQLkfkfc5FEYNAeYWdkPPTs7hPFNU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=r1H+CCog; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="r1H+CCog" Message-ID: <28de0e9b-bbe0-4b9d-bd22-8efe0f456ec1@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1726069683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CvmloE06/v+am5tMLnrNeQIH8UZ8+bT+4FORftz19Pc=; b=r1H+CCogUs/QFDwnI+iZWWc3H3qvu2aQCseOfeo2xKG8kYIxrILoTnCVlq4FOHZsAPZYPv VmRU9fq/ebYVEo351u+GvUjYfsEaAzM0nrCCF2g7NrK4+q8NsZ2R5qCpCvBDDSKypJV+5I MA1IKmjTLmUm6zIIqIUtLvzxL1rn6B4= Date: Wed, 11 Sep 2024 16:47:54 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] net: ethernet: ag71xx: Remove dead code To: Muhammad Usama Anjum , Chris Snook , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Oleksij Rempel Cc: kernel@collabora.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240911135828.378317-1-usama.anjum@collabora.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20240911135828.378317-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 11/09/2024 14:58, Muhammad Usama Anjum wrote: > The err variable isn't being used anywhere other than getting > initialized to 0 and then it is being checked in if condition. The > condition can never be true. Remove the err and deadcode. > > Move the rx_dropped counter above when skb isn't found. > > Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v1: > - Move the rx_dropped counter above when skb isn't found. > --- > drivers/net/ethernet/atheros/ag71xx.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c > index db2a8ade62055..2effceeb191db 100644 > --- a/drivers/net/ethernet/atheros/ag71xx.c > +++ b/drivers/net/ethernet/atheros/ag71xx.c > @@ -1619,7 +1619,6 @@ static int ag71xx_rx_packets(struct ag71xx *ag, int limit) > unsigned int i = ring->curr & ring_mask; > struct ag71xx_desc *desc = ag71xx_ring_desc(ring, i); > int pktlen; > - int err = 0; > > if (ag71xx_desc_empty(desc)) > break; > @@ -1643,20 +1642,16 @@ static int ag71xx_rx_packets(struct ag71xx *ag, int limit) > skb = napi_build_skb(ring->buf[i].rx.rx_buf, ag71xx_buffer_size(ag)); > if (!skb) { > skb_free_frag(ring->buf[i].rx.rx_buf); > + ndev->stats.rx_dropped++; > goto next; > } > > skb_reserve(skb, offset); > skb_put(skb, pktlen); > > - if (err) { > - ndev->stats.rx_dropped++; > - kfree_skb(skb); > - } else { > - skb->dev = ndev; > - skb->ip_summed = CHECKSUM_NONE; > - list_add_tail(&skb->list, &rx_list); > - } > + skb->dev = ndev; > + skb->ip_summed = CHECKSUM_NONE; > + list_add_tail(&skb->list, &rx_list); > > next: > ring->buf[i].rx.rx_buf = NULL; Reviewed-by: Vadim Fedorenko