From: Edward Cree <ecree@solarflare.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<kuba@kernel.org>, <saeedm@mellanox.com>, <leon@kernel.org>,
<michael.chan@broadcom.com>, <vishal@chelsio.com>,
<jeffrey.t.kirsher@intel.com>, <idosch@mellanox.com>,
<aelior@marvell.com>, <peppe.cavallaro@st.com>,
<alexandre.torgue@st.com>, <jhs@mojatatu.com>,
<xiyou.wangcong@gmail.com>, <pablo@netfilter.org>,
<mlxsw@mellanox.com>
Subject: Re: [patch net-next v4 01/10] flow_offload: Introduce offload of HW stats type
Date: Mon, 9 Mar 2020 17:46:57 +0000 [thread overview]
Message-ID: <28ec0ed4-38b6-bb27-d769-5bf9d1d4f09c@solarflare.com> (raw)
In-Reply-To: <20200309173412.GF13968@nanopsycho.orion>
On 09/03/2020 17:34, Jiri Pirko wrote:
> Mon, Mar 09, 2020 at 05:52:16PM CET, ecree@solarflare.com wrote:
>> An enum type seems safer.
> Well, it's is a bitfield, how do you envision to implement it. Have enum
> value for every combination? I don't get it.
enum flow_action_stats_type {
FLOW_ACTION_HW_STATS_TYPE_DISABLED=0,
FLOW_ACTION_HW_STATS_TYPE_IMMEDIATE=BIT(0),
FLOW_ACTION_HW_STATS_TYPE_DELAYED=BIT(1),
FLOW_ACTION_HW_STATS_TYPE_ANY=(FLOW_ACTION_HW_STATS_TYPE_IMMEDIATE |
FLOW_ACTION_HW_STATS_TYPE_DELAYED),
};
It's not a requirement of the language for every value used withan
enumeration to be a defined enumerator value, so if someone ends up
putting (FLOW_ACTION_HW_STATS_TYPE_FOO | FLOW_ACTION_HW_STATS_TYPE_BAR)
into (say) a driver that supports only FOO and BAR, that will work
just fine. I don't see what problem you expect to occur here.
-ed
next prev parent reply other threads:[~2020-03-09 17:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 11:40 [patch net-next v4 00/10] net: allow user specify TC action HW stats type Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 01/10] flow_offload: Introduce offload of " Jiri Pirko
2020-03-09 16:52 ` Edward Cree
2020-03-09 17:34 ` Jiri Pirko
2020-03-09 17:46 ` Edward Cree [this message]
2020-03-10 11:19 ` Jiri Pirko
2020-03-09 21:36 ` Jakub Kicinski
2020-03-09 22:27 ` Edward Cree
2020-03-09 22:38 ` Jakub Kicinski
2020-03-10 11:22 ` Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 02/10] ocelot_flower: use flow_offload_has_one_action() helper Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 03/10] flow_offload: check for basic action hw stats type Jiri Pirko
2020-03-09 10:23 ` Jose Abreu
2020-03-09 12:04 ` Jiri Pirko
2020-03-09 13:31 ` Jose Abreu
2020-03-09 13:43 ` Jiri Pirko
2020-03-09 16:52 ` Edward Cree
2020-03-09 17:32 ` Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 04/10] mlxsw: spectrum_flower: Do not allow mixing HW stats types for actions Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 05/10] mlxsw: restrict supported HW stats type to "any" Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 06/10] flow_offload: introduce "immediate" HW stats type and allow it in mlxsw Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 07/10] flow_offload: introduce "delayed" HW stats type and allow it in mlx5 Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 08/10] mlxsw: spectrum_acl: Ask device for rule stats only if counter was created Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 09/10] flow_offload: introduce "disabled" HW stats type and allow it in mlxsw Jiri Pirko
2020-03-07 11:40 ` [patch net-next v4 10/10] sched: act: allow user to specify type of HW stats for a filter Jiri Pirko
2020-03-09 4:09 ` [patch net-next v4 00/10] net: allow user specify TC action HW stats type David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ec0ed4-38b6-bb27-d769-5bf9d1d4f09c@solarflare.com \
--to=ecree@solarflare.com \
--cc=aelior@marvell.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=peppe.cavallaro@st.com \
--cc=saeedm@mellanox.com \
--cc=vishal@chelsio.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox