From: Florian Fainelli <f.fainelli@gmail.com>
To: kiki good <jqiaoulk@gmail.com>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics
Date: Thu, 20 Jul 2017 08:28:53 -0700 [thread overview]
Message-ID: <2912aa5b-b05d-faf3-f2db-4f2affa4b35e@gmail.com> (raw)
In-Reply-To: <CACM3AayYV-x1b8FpPCMdsSqkFEfJskkP0k9Dfsc5QjqTUbhKuA@mail.gmail.com>
On 07/20/2017 03:13 AM, kiki good wrote:
> Hi David:
>
> I am sorry for missing the commit log message;Since I did conversation
> with Florian Fainelli about this patch in another email thread
> "[PATCH] net: systemport: Support 64bit statistics", i incorrectly
> thought it was unnecessary to add the commit log again when submitting
> the revised patch.
>
> The reason for keeping both .ndo_get_stats and 64-bit
> .ndo_get_stats64 comes from Florian, suggesting that because there is
> no harm in keeping bcm_sysport_get_stats and we can always deprecate
> it later, it is just to minimize the amount of changes to review.
Yes, my bad for suggesting that, Jmqiao, please resubmit with a commit
message that is essentially your paragraph after the "Why do we need
this change?" question (don't include the question in the commit message).
Thanks!
>
> Why do we need this change ?
> When using Broadcom Systemport device in 32bit Platform, ifconfig can
> only report up to 4G tx,rx status, which will be wrapped to 0 when the
> number of incoming or outgoing packets exceeds 4G, only taking
> around 2 hours in busy network environment (such as streaming).
> Therefore, it makes hard for network diagnostic tool to get reliable
> statistical result, so the patch is used to add 64bit support for
> Broadcom Systemport device in 32bit Platform.
>
> Thanks
> Jmqiao
>
> On Thu, Jul 20, 2017 at 6:25 AM, David Miller <davem@davemloft.net> wrote:
>> From: "Jianming.qiao" <jqiaoulk@gmail.com>
>> Date: Wed, 19 Jul 2017 01:18:40 +0100
>>
>>> Signed-off-by: Jianming.qiao <kiki-good@hotmail.com>
>>
>> Supporting both deprecated .ndo_get_stats and 64-bit .ndo_get_stats64
>> at the same time makes no sense.
>>
>> .ndo_get_stats will never be called if .ndo_get_stats64 is non-NULL
>>
>> The lack of a commit log message, explaining in detail, why you are
>> doing this and why you are doing it this way, concerns me as well.
>>
>> This submission so far has been a bit of a mess. You don't
>> communicate enough, your commit message is empty, and therefore we
>> have no idea why you are doing things, and in particular the reasons
>> for your decisions.
>>
>> I'm not applying this, sorry.
--
Florian
next prev parent reply other threads:[~2017-07-20 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 0:18 [PATCH v2 net-next] net: systemport: Support 64bit statistics Jianming.qiao
2017-07-20 5:25 ` David Miller
2017-07-20 10:13 ` kiki good
2017-07-20 15:28 ` Florian Fainelli [this message]
2017-07-20 15:44 ` Stephen Hemminger
2017-07-20 21:59 ` kiki good
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2912aa5b-b05d-faf3-f2db-4f2affa4b35e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jqiaoulk@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).