From: Paul Moore <paul@paul-moore.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: casey@schaufler-ca.com, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: xfrm: Can "struct netlbl_audit" be killed?
Date: Thu, 24 Apr 2014 10:40:37 -0400 [thread overview]
Message-ID: <29136798.pGbRqWE1nJ@sifl> (raw)
In-Reply-To: <201404242329.FBF00065.OOQtHFMOLFSVFJ@I-love.SAKURA.ne.jp>
On Thursday, April 24, 2014 11:29:08 PM Tetsuo Handa wrote:
> Paul Moore wrote:
> > On Thursday, April 24, 2014 08:51:35 PM Tetsuo Handa wrote:
> > > Hello, Casey and Paul.
> > >
> > > At the ipsec-next tree,
> > >
> > > /* Audit Information */
> > > struct xfrm_audit {
> > >
> > > u32 secid;
> > > kuid_t loginuid;
> > > unsigned int sessionid;
> > >
> > > };
> > >
> > > has just been killed
> > > (
> > > https://git.kernel.org/cgit/linux/kernel/git/klassert/ipsec-next.git/com
> > > mit
> > > /?id=f1370cc4a01e61007ab3020c761cef6b88ae3729 and
> > > https://git.kernel.org/cgit/linux/kernel/git/klassert/ipsec-next.git/com
> > > mit
> > > /?id=2e71029e2c32ecd59a2e8f351517bfbbad42ac11 ) because these arguments
> > > are
> > > always calculated from current thread's security context.
> >
> > Before we go to far, is it always true for AF_KEY that "current" is set to
> > the sending process? If the answer is no, I think we have a problem.
>
> Speak of "struct xfrm_audit", I think the answer is yes, or commit ab5f5e8b
> "[XFRM]: xfrm audit calls" is wrong.
I'm not assuming that ab5f5e8b is correct. It would be nice to know for sure
that current is always equal to the sending process for AF_KEY, and that isn't
something I'm certain is true off the top of my head.
--
paul moore
www.paul-moore.com
prev parent reply other threads:[~2014-04-24 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 11:51 xfrm: Can "struct netlbl_audit" be killed? Tetsuo Handa
2014-04-24 13:18 ` Paul Moore
2014-04-24 14:29 ` Tetsuo Handa
2014-04-24 14:40 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29136798.pGbRqWE1nJ@sifl \
--to=paul@paul-moore.com \
--cc=casey@schaufler-ca.com \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).