From: Marc Dietrich <marvin24@gmx.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Thierry Reding <thierry.reding@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Alexandre Courbot <gnurou@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio
Date: Tue, 23 Feb 2016 14:42:55 +0100 [thread overview]
Message-ID: <2927215.6IlWnjRTgT@fb07-iapwap2> (raw)
In-Reply-To: <2463567.tt0f0ingYr@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 2350 bytes --]
Am Dienstag, 23. Februar 2016, 14:17:17 CET schrieb Arnd Bergmann:
> On Tuesday 23 February 2016 11:38:52 Marc Dietrich wrote:
> > Am Dienstag, 23. Februar 2016, 11:31:40 CET schrieb Arnd Bergmann:
> > > On Tuesday 23 February 2016 11:15:31 Arnd Bergmann wrote:
> > > > On Thursday 18 February 2016 21:04:49 Johannes Berg wrote:
> > > > > On Tue, 2016-01-26 at 09:42 +0100, Johannes Berg wrote:
> > > > Just for my curiosity: what is the difference between a rfkill-gpio
> > > > device and a gpio-keys device with a KEY_RFKILL code?
> > > >
> > > > arch/arm/boot/dts/bcm4708-netgear-r6250.dts and others seem to
> > > > do the second approach in DT so they don't need to create the
> > > > platform device.
> > >
> > > I found the answer now (after discussing on IRC): just
> > > for reference: KEY_RFKILL is for sending the event to the kernel
> > > when a user presses the gpio butting, this rfkill-gpio turns
> > > the devices on or off when after an RFKILL event is received.
> >
> > yes, paz00 has no hw key. rfkill is triggered via software (rfkill) only.
> > The problem in the past was how to describe such a device in the device
> > tree.
> >
> > Strictly speaking, there is no rfkill device hardware (just an interface).
> > The only hardware that exists is in our case is connected to a hard wired
> > usb bus (wifi dongle), which makes it complicated to attach a DT property
> > or subdevice to it. And a standalone device-tree entry for a non hardware
> > device was rejected in the past.
>
> Ah, so the problem of attaching DT properties to a USB device has recently
> been solved, see subject "USB: core: let USB device know device node".
>
> Would that work for you? With this, the USB driver can simply look at
> the optional DT properties of the USB function to implement its rfkill
> callbacks.
oh, that looks indeed interesting. The question is now if rfkill is a property
of a device or a subdevice itself. The latter one would only require addition
of device-tree instantiation of rfkill, while with the former one, the (or
all) usb driver(s) need to be modified to accept device tree properties,
especially gpios. The driver would then be responsible to add an rfkill
"device".
IMHO (and unfortunately), it's just a property (a way to specify the relevant
gpios), making the solution again hard to archive.
Marc
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-23 13:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 9:03 [PATCHv2 0/4] net: rfkill: gpio: replace platform data with build-in property Heikki Krogerus
2016-01-25 9:03 ` [PATCHv2 1/4] net: rfkill: add rfkill_find_type function Heikki Krogerus
2016-01-25 9:03 ` [PATCHv2 2/4] net: rfkill: gpio: get the name and type from device property Heikki Krogerus
2016-01-25 9:03 ` [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Heikki Krogerus
[not found] ` <1453712629-143317-4-git-send-email-heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-25 12:18 ` Thierry Reding
[not found] ` <20160125121840.GA20452-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2016-01-25 20:59 ` [PATCHv2 3/4] ARM: tegra: use build-in device properties withrfkill_gpio Marc Dietrich
2016-01-26 8:46 ` Johannes Berg
[not found] ` <1453798016.2759.5.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-01-26 8:52 ` [PATCHv2 3/4] ARM: tegra: use build-in device propertieswithrfkill_gpio Marc Dietrich
2016-01-26 8:42 ` [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Johannes Berg
2016-02-18 20:04 ` Johannes Berg
[not found] ` <1455825889.2084.16.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-02-19 18:03 ` Thierry Reding
2016-02-23 10:31 ` Johannes Berg
2016-02-23 10:15 ` Arnd Bergmann
2016-02-23 10:31 ` Arnd Bergmann
2016-02-23 10:38 ` Marc Dietrich
2016-02-23 13:17 ` Arnd Bergmann
2016-02-23 13:42 ` Marc Dietrich [this message]
2016-02-23 15:06 ` Arnd Bergmann
2016-02-23 20:39 ` Johannes Berg
2016-01-25 9:03 ` [PATCHv2 4/4] net: rfkill: gpio: remove rfkill_gpio_platform_data Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2927215.6IlWnjRTgT@fb07-iapwap2 \
--to=marvin24@gmx.de \
--cc=arnd@arndb.de \
--cc=gnurou@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox