From: Sven Eckelmann <sven@narfation.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Simon Wunderlich <sw@simonwunderlich.de>,
davem@davemloft.net, netdev@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default
Date: Fri, 25 May 2018 12:50:27 +0200 [thread overview]
Message-ID: <2946906.LStWHluSmG@bentobox> (raw)
In-Reply-To: <fec8128d-0021-74db-b047-305fb1f70104@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On Freitag, 25. Mai 2018 13:33:59 CEST Sergei Shtylyov wrote:
[...]
> > --- a/net/batman-adv/Kconfig
> > +++ b/net/batman-adv/Kconfig
> > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS
> > bool "batman-adv debugfs entries"
> > depends on BATMAN_ADV
> > depends on DEBUG_FS
> > - default y
> > + default n
>
> N is the default default. :-) You don't need this line.
Hm, looks like this would have to be changed in a lot of places (~782
according to `git grep 'default n$'|wc -l` in my slightly outdated linux-
next). Do you want to fix it everywhere? Might be good to get this integrated
in checkpatch.pl when this will become a new policy.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-25 10:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 12:02 [PATCH 0/8] pull request for net-next: batman-adv 2017-05-24 Simon Wunderlich
2018-05-24 12:02 ` [PATCH 1/8] batman-adv: Start new development cycle Simon Wunderlich
2018-05-24 12:02 ` [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default Simon Wunderlich
2018-05-25 10:33 ` Sergei Shtylyov
2018-05-25 10:50 ` Sven Eckelmann [this message]
2018-05-25 11:13 ` Sergei Shtylyov
[not found] ` <6fd70d33-11f7-33dd-3b11-e5031fe46466-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2018-05-25 11:15 ` Sven Eckelmann
2018-05-25 15:56 ` Sergei Shtylyov
2018-05-25 18:39 ` David Miller
2018-05-25 18:20 ` Joe Perches
2018-05-24 12:02 ` [PATCH 3/8] batman-adv: Avoid old nodes disabling multicast optimizations completely Simon Wunderlich
2018-05-24 12:02 ` [PATCH 4/8] batman-adv: Avoid bool in structures Simon Wunderlich
2018-05-24 12:02 ` [PATCH 5/8] batman-adv: Remove unused dentry without DEBUGFS Simon Wunderlich
2018-05-24 12:02 ` [PATCH 6/8] batman-adv: fix batadv_interface_tx()'s return type Simon Wunderlich
2018-05-24 12:02 ` [PATCH 7/8] batman-adv: disable ethtool link speed detection when auto negotiation off Simon Wunderlich
2018-05-24 12:03 ` [PATCH 8/8] batman-adv: enable B.A.T.M.A.N. V compilation by default Simon Wunderlich
2018-05-24 12:09 ` Joe Perches
2018-05-24 15:03 ` [PATCH 0/8] pull request for net-next: batman-adv 2017-05-24 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2946906.LStWHluSmG@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox