From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: selftests/bpf doesn't compile Date: Thu, 14 Sep 2017 09:33:48 -0600 Message-ID: <295553a4-aadc-e5d1-229e-22d1966bc9f5@kernel.org> References: <20170908111923.27434-1-thomas@m3y3r.de> <20170908230155.esge2mctk5d5g7gb@ast-mbp> <59B32231.9090406@iogearbox.net> Reply-To: shuah@kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Networking To: Daniel Borkmann , Alexei Starovoitov , Thomas Meyer Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Alexei and Daniel, bpf test depends on clang and fails to compile when ------------------------------------------------------ make -C tools/testing/selftests/bpf run_tests make: clang: Command not found Makefile:39: recipe for target '.linux-kselftest/tools/testing/selftests/bpf/test_pkt_access.o' failed make: *** [./linux-kselftest/tools/testing/selftests/bpf/test_pkt_access.o] Error 127 make: Leaving directory '.linux-kselftest/tools/testing/selftests/bpf' With "make TARGETS=bpf kselftest" it fails earlier: make[3]: Entering directory './linux-kselftest/tools/lib/bpf' Makefile:40: tools/scripts/Makefile.arch: No such file or directory Makefile:84: tools/build/Makefile.feature: No such file or directory Makefile:143: tools/build/Makefile.include: No such file or directory make[3]: *** No rule to make target 'tools/build/Makefile.include'. Stop. make[3]: Leaving directory '.linux-kselftest/tools/lib/bpf' Makefile:34: recipe for target './linux-kselftest/tools/testing/selftests/bpf/libbpf.a' failed make[2]: *** [./linux-kselftest/tools/testing/selftests/bpf/libbpf.a] Error 2 make[2]: Leaving directory './linux-kselftest/tools/testing/selftests/bpf' Makefile:69: recipe for target 'all' failed make[1]: *** [all] Error 2 Makefile:1190: recipe for target 'kselftest' failed make: *** [kselftest] Error 2 -------------------------------------------------------------- Is bpf test intended to be run in kselftest run? The clang dependency might not be met on majority of the systems. Is this a hard dependency?? Would it make sense to create a special target for bpf test? We do have a few tests that do that now. TARGETS_HOTPLUG = cpu-hotplug TARGETS_HOTPLUG += memory-hotplug I could add a special target for bpf TARGET_BPF perhaps and exclude it from the run_tests. Please let me know your thoughts on this. thanks, -- Shuah