From: Arnd Bergmann <arnd@arndb.de>
To: Phil Reid <preid@electromag.com.au>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
peppe.cavallaro@st.com, davem@davemloft.net,
vbridger@opensource.altera.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v4 1/4] stmmac: create of compatible mdio bus for stmacc driver
Date: Wed, 09 Dec 2015 10:22:20 +0100 [thread overview]
Message-ID: <2980072.p4qU8YfBxO@wuerfel> (raw)
In-Reply-To: <56679641.7060101@electromag.com.au>
On Wednesday 09 December 2015 10:47:29 Phil Reid wrote:
> On 9/12/2015 10:15 AM, kbuild test robot wrote:
>
> >
> > url: https://github.com/0day-ci/linux/commits/Phil-Reid/stmmac-create-of-compatible-mdio-bus-for-stmacc-driver/20151209-094242
> > config: x86_64-randconfig-b0-12090825 (attached as .config)
> > reproduce:
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c: In function 'stmmac_mdio_register':
> >>> drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c:226:17: error: 'struct stmmac_mdio_bus_data' has no member named 'reset_gpio'
> > mdio_bus_data->reset_gpio = -1;
> > ^
>
> G'day Arnd,
>
> I got the above error from kbuild test robot. When changing to if (IS_ENABLED(CONFIG_OF)).
> This was existing code that I moved into this conditional.
> reset_gpio member only exists when CONFIG_OF is defined.
> So it looks like I need to move that code back to the #if.
> unless you have an alternate suggestion.
I think it would be slightly nicer to remove the #ifdef in the header file
as well and always have those members, it's only a few bytes in any system
that we are saving here and there are only two actual users of this driver
that don't already require CONFIG_OF (blackfin ezkit and mips loongson32).
If Giuseppe prefers to keep the #ifdef, going back to your previous
version is fine with me too.
Arnd
next prev parent reply other threads:[~2015-12-09 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 1:41 [PATCH v4 0/4] stmmac: Fixed Phy & PTP fixes Phil Reid
2015-12-09 1:41 ` [PATCH v4 1/4] stmmac: create of compatible mdio bus for stmacc driver Phil Reid
[not found] ` <1449625269-46078-2-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2015-12-09 2:15 ` kbuild test robot
2015-12-09 2:37 ` David Miller
2015-12-09 2:47 ` Phil Reid
2015-12-09 9:22 ` Arnd Bergmann [this message]
2015-12-09 1:41 ` [PATCH v4 2/4] stmmac: Correct documentation on stmmac clocks Phil Reid
2015-12-09 1:41 ` [PATCH v4 3/4] stmmac: Fix calculations for ptp counters when clock input = 50Mhz Phil Reid
[not found] ` <1449625269-46078-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2015-12-09 1:41 ` [PATCH v4 4/4] stmmac: socfpga: Provide dt node to config ptp clk source Phil Reid
2015-12-09 4:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2980072.p4qU8YfBxO@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=vbridger@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox