From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Jonathan Toppins <jtoppins@redhat.com>
Cc: "netdev @ vger . kernel . org" <netdev@vger.kernel.org>,
Jussi Maki <joamaki@gmail.com>
Subject: Re: [PATCH net v2 0/2] bonding: fix NULL deref in bond_rr_gen_slave_id
Date: Tue, 20 Sep 2022 10:53:56 -0700 [thread overview]
Message-ID: <29846.1663696436@famine> (raw)
In-Reply-To: <cover.1663694476.git.jtoppins@redhat.com>
Jonathan Toppins <jtoppins@redhat.com> wrote:
>Fix a NULL dereference of the struct bonding.rr_tx_counter member because
>if a bond is initially created with an initial mode != zero (Round Robin)
>the memory required for the counter is never created and when the mode is
>changed there is never any attempt to verify the memory is allocated upon
>switching modes.
>
>The first patch provides a selftest to demonstrate the issue and the
>second patch fixes the issue.
>
>Jonathan Toppins (2):
> selftests: bonding: cause oops in bond_rr_gen_slave_id
> bonding: fix NULL deref in bond_rr_gen_slave_id
For the series:
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
> drivers/net/bonding/bond_main.c | 15 +++---
> .../selftests/drivers/net/bonding/Makefile | 3 +-
> .../bonding/bond-arp-interval-causes-panic.sh | 49 +++++++++++++++++++
> 3 files changed, 57 insertions(+), 10 deletions(-)
> create mode 100755 tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh
>
>--
>2.31.1
>
next prev parent reply other threads:[~2022-09-20 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 17:45 [PATCH net v2 0/2] bonding: fix NULL deref in bond_rr_gen_slave_id Jonathan Toppins
2022-09-20 17:45 ` [PATCH net v2 1/2] selftests: bonding: cause oops " Jonathan Toppins
2022-09-20 17:45 ` [PATCH net v2 2/2] bonding: fix NULL deref " Jonathan Toppins
2022-09-20 17:53 ` Jay Vosburgh [this message]
2022-09-22 14:10 ` [PATCH net v2 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29846.1663696436@famine \
--to=jay.vosburgh@canonical.com \
--cc=joamaki@gmail.com \
--cc=jtoppins@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).