From: David Ahern <dsahern@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>, davem <davem@davemloft.net>
Subject: Re: [PATCH net] ipv6: fix the check before getting the cookie in rt6_get_cookie
Date: Thu, 6 Jun 2019 16:44:47 -0600 [thread overview]
Message-ID: <29c20dfb-3428-32ea-43d1-eae2def70365@gmail.com> (raw)
In-Reply-To: <CADvbK_e4szaBKY6bJ3d-aE9XvSvCqtAJftCa=g0HpRpB6a9hqA@mail.gmail.com>
On 6/6/19 10:10 AM, Xin Long wrote:
> On Thu, Jun 6, 2019 at 11:35 PM David Ahern <dsahern@gmail.com> wrote:
>>
>> On 6/2/19 5:10 AM, Xin Long wrote:
>>> In Jianlin's testing, netperf was broken with 'Connection reset by peer',
>>> as the cookie check failed in rt6_check() and ip6_dst_check() always
>>> returned NULL.
>>
>> Any particular test or setup that is causing the reset? I do not see
>> that problem in general.
>>
> by running the script below, netperf ends up with:
>
> Connection reset by peer
> netperf: remote error 104
>
No luck reproducing on 5.1 or 5.2. I get the theory though - resetting
the mtu to change exceptions. Interesting test case to add under selftests
prev parent reply other threads:[~2019-06-06 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 11:10 [PATCH net] ipv6: fix the check before getting the cookie in rt6_get_cookie Xin Long
2019-06-06 0:01 ` David Miller
2019-06-06 15:35 ` David Ahern
2019-06-06 16:10 ` Xin Long
2019-06-06 22:44 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29c20dfb-3428-32ea-43d1-eae2def70365@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).