Re: [PATCH net-next v3 8/9] can: ems_pci: Remove unnecessary (void*) conversions

Marc Kleine-Budde
2023-07-17T07:33:18Z

[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]

On 17.07.2023 15:30:33, yunchuan wrote:
>
> On 2023/7/17 15:07, Marc Kleine-Budde wrote:
> > On 17.07.2023 08:52:42, Marc Kleine-Budde wrote:
> > > On 17.07.2023 11:12:21, Wu Yunchuan wrote:
> > > > No need cast (void*) to (struct ems_pci_card *).
> > > >
> > > > Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com>
> > > > Acked-by: Marc Kleine-Budde<mkl@pengutronix.de>
> > > Please add a space between my name and my e-mail address, so that it
> > > reads:
> > >
> > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > >
> > > nitpick:
> > > You should add your S-o-b as the last trailer.
> > BTW: The threading of this series is still broken. Make sure you send
> > the whole patch series with one single "git send-email" command. For
> > regular contribution you might have a look at the "b4" [1] tool.
>
> Hi,
>
> Thanks for you suggestions, I use 'git send-email' to send patch.
> I messing up the patch's order in different patchset. This might be the
> reason of the broken threading.
> Really sorry for this, I will take careful next time.

You should send _all_ 9 patches in the series with a _single_ "git
send-email" command. There's no risk to mess up the order.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]