From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: r8169 needs CONFIG_REALTEK_PHY Date: Mon, 20 Aug 2018 13:39:58 -0700 Message-ID: <29f25302-6a60-4a44-fd65-26b5a15ff35a@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Marc Dionne , hkallweit1@gmail.com, netdev , David Miller Return-path: Received: from mail-qt0-f180.google.com ([209.85.216.180]:35416 "EHLO mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726237AbeHTX5N (ORCPT ); Mon, 20 Aug 2018 19:57:13 -0400 Received: by mail-qt0-f180.google.com with SMTP id r21-v6so17792432qtm.2 for ; Mon, 20 Aug 2018 13:40:07 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 08/20/2018 12:44 PM, Marc Dionne wrote: > The r8169 adapter in one of my machines was not working after updating > to a current kernel from the merge window, which was fixed by enabling > CONFIG_REALTEK_PHY. > > So in addition to "select PHYLIB", should CONFIG_R8169 not also be > doing "select CONFIG_REALTEK_PHY" ? This is fixed in Linus' tree now with: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bfdd19ad80f203f42f05fd32a31c678c9c524ef9 -- Florian