From: Luke Howard <lukeh@padl.com>
To: Cedric Jehasse <cedric.jehasse@gmail.com>
Cc: Cedric Jehasse <cedric.jehasse@luminex.be>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kieran Tyrrell <kieran@sienda.com>,
Max Hunter <max@huntershome.org>
Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper
Date: Thu, 28 May 2026 20:15:10 +1000 [thread overview]
Message-ID: <2E4F8243-8687-4591-A03D-4402D4FBEC02@padl.com> (raw)
In-Reply-To: <CABvLYuA85b1X9wHH073HPX=xv_1uZ2+anhcr+3MMkoVF-3DVcA@mail.gmail.com>
> On 28 May 2026, at 6:11 pm, Cedric Jehasse <cedric.jehasse@gmail.com> wrote:
>
> On Thu, May 28, 2026 at 2:17 AM Luke Howard <lukeh@padl.com> wrote:
>
>> This actually makes more sense also now that you pointed out that AVB mode is set on the ingress, not egress, port: configuring CBS should stay out of setting any of the AVB mode bits. Are you planning to submit a MQPRIO patch? If not, shall I just wait for your CBS patch to land, and then rebase my AVB patch series on top of net-next?
>
> No, I don't have changes to support MQPRIO in the driver. I use the
> default FPri/Qpri mappings at the moment.
This is a salient point: in my MQPRIO patch series, offloaded TCs 2 and 1 represent AVB classes (with 0 representing non-AVB traffic). This is the most natural mapping to take advantage of the switches’ native AVB support.
But there’s an alternate mapping where TCs represent switch queues and can be used to configure arbitrary FPri/QPri mappings.
It would be good to support both, particularly for switches with >4 queues. Maybe this can be keyed the presence of the DT property (now renamed, marvell,avb-mode).
next prev parent reply other threads:[~2026-05-28 10:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 10:56 [PATCH net-next 0/2] net: dsa: mv88e6xxx: add support for credit based shaper Cedric Jehasse via B4 Relay
2026-05-22 10:56 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: use the hw tx queues Cedric Jehasse via B4 Relay
2026-05-25 9:26 ` Marek Behún
2026-05-26 8:57 ` Cedric Jehasse
2026-05-26 12:13 ` Andrew Lunn
2026-05-26 13:15 ` Paolo Abeni
2026-05-22 10:56 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper Cedric Jehasse via B4 Relay
2026-05-26 0:32 ` Luke Howard
2026-05-26 5:37 ` Luke Howard
2026-05-26 11:28 ` Cedric Jehasse
2026-05-26 12:35 ` Luke Howard
2026-05-28 0:17 ` Luke Howard
2026-05-28 8:11 ` Cedric Jehasse
2026-05-28 10:15 ` Luke Howard [this message]
2026-05-28 12:46 ` Andrew Lunn
2026-05-28 23:13 ` Luke Howard
2026-05-26 13:15 ` Paolo Abeni
2026-05-27 23:52 ` Luke Howard
2026-05-28 9:19 ` Cedric Jehasse
2026-05-28 9:49 ` Luke Howard
2026-06-19 5:00 ` Luke Howard
2026-06-19 5:59 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E4F8243-8687-4591-A03D-4402D4FBEC02@padl.com \
--to=lukeh@padl.com \
--cc=andrew@lunn.ch \
--cc=cedric.jehasse@gmail.com \
--cc=cedric.jehasse@luminex.be \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kieran@sienda.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=max@huntershome.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox