From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yajun Deng <yajun.deng@linux.dev>,
davem@davemloft.net, kuba@kernel.org, ryazanov.s.a@gmail.com,
johannes.berg@intel.com, avagin@gmail.com,
vladimir.oltean@nxp.com, cong.wang@bytedance.com,
roopa@cumulusnetworks.com, zhudi21@huawei.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: rtnetlink: Fix rtnl_dereference return value is NULL
Date: Thu, 8 Jul 2021 10:08:27 +0200 [thread overview]
Message-ID: <2a00ac67-f5bc-8ff8-3737-ebea83777f87@gmail.com> (raw)
In-Reply-To: <20210708073745.13797-1-yajun.deng@linux.dev>
On 7/8/21 9:37 AM, Yajun Deng wrote:
> rtnl_dereference() may be return NULL in rtnl_unregister(),
> so add this case handling.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> net/core/rtnetlink.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
I do not see a use case for this.
None of rtnl_unregister() callers check the return value anyway.
Can you elaborate ?
If this was a bug fix, we would need a Fixes: tag.
If this is something you need for an upcoming work, you would need to tag
this for net-next tree.
Thanks.
prev parent reply other threads:[~2021-07-08 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 7:37 [PATCH] net: rtnetlink: Fix rtnl_dereference return value is NULL Yajun Deng
2021-07-08 8:08 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a00ac67-f5bc-8ff8-3737-ebea83777f87@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=avagin@gmail.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=ryazanov.s.a@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=yajun.deng@linux.dev \
--cc=zhudi21@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).