From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3] r8169: use the extended tally counter available from RTL8125
Date: Sat, 12 Oct 2024 23:43:04 +0200 [thread overview]
Message-ID: <2a11adb9-bcd9-4418-8fc8-b751c8ce13b4@gmail.com> (raw)
In-Reply-To: <20241011155816.09e4e3d5@kernel.org>
On 12.10.2024 00:58, Jakub Kicinski wrote:
> On Fri, 11 Oct 2024 14:40:58 +0200 Heiner Kallweit wrote:
>> +static const char rtl8125_gstrings[][ETH_GSTRING_LEN] = {
>> + "tx_bytes",
>> + "rx_bytes",
>
> these I presume are covered by @get_eth_mac_stats ?
>
>> + "tx_pause_on",
>> + "tx_pause_off",
>> + "rx_pause_on",
>> + "rx_pause_off",
>
> and if you want to add custom pause string you should first
> implement @get_pause_stats
Thanks for the hints!
next prev parent reply other threads:[~2024-10-12 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 12:40 [PATCH net-next v3] r8169: use the extended tally counter available from RTL8125 Heiner Kallweit
2024-10-11 22:58 ` Jakub Kicinski
2024-10-12 21:43 ` Heiner Kallweit [this message]
2024-10-14 20:48 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a11adb9-bcd9-4418-8fc8-b751c8ce13b4@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).