Re: Re: [PATCH net-next v5 3/3] riscv: dts: eswin: eic7700-hifive-premier-p550: enable Ethernet controller

[李志 <lizhi2@eswincomputing.com>]

> -----原始邮件-----
> 发件人: "Simon Horman" <horms@kernel.org>
> 发送时间:2026-03-26 02:03:30 (星期四)
> 收件人: lizhi2@eswincomputing.com
> 抄送: devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, pritesh.patel@einfochips.com, weishangjuan@eswincomputing.com
> 主题: Re: [PATCH net-next v5 3/3] riscv: dts: eswin: eic7700-hifive-premier-p550: enable Ethernet controller
> 
> On Tue, Mar 24, 2026 at 03:34:08PM +0800, lizhi2@eswincomputing.com wrote:
> > From: Zhi Li <lizhi2@eswincomputing.com>
> > 
> > Enable the on-board Gigabit Ethernet controller on the
> > HiFive Premier P550 development board.
> > 
> > Signed-off-by: Zhi Li <lizhi2@eswincomputing.com>
> > ---
> >  .../dts/eswin/eic7700-hifive-premier-p550.dts | 42 ++++++++++++
> >  arch/riscv/boot/dts/eswin/eic7700.dtsi        | 66 +++++++++++++++++++
> >  2 files changed, 108 insertions(+)
> 
> Unfortunately this does not compile:
> 
> $ ARCH=riscv make allmodconfig dtbs
> ...
>   DTC     arch/riscv/boot/dts/eswin/eic7700-hifive-premier-p550.dtb
> arch/riscv/boot/dts/eswin/eic7700.dtsi:300.28-330.5: ERROR (phandle_references): /soc/ethernet@50400000: Reference to non-existent node or label "clk"
> ...
> 
> -- 
> pw-bot: changes-requested

Hi Simon,

Thanks for your review.

You're right, this build failure is due to an invalid clock reference
("clk") in the Ethernet node, which does not correspond to an existing
clock provider label in the current DTS.

For context, this was discussed during an earlier revision:
https://lore.kernel.org/lkml/5dea8ce0.4435.19c471231f5.Coremail.lizhi2@eswincomputing.com/

The EIC7700 clock controller support has since been applied, so I will
update the DTS to reference the correct clock provider and ensure the
build passes cleanly.

I will fix this in the next revision (v6).

Thanks,
Zhi Li