From mboxrd@z Thu Jan  1 00:00:00 1970
From: Li Yang <leoli@freescale.com>
Subject: Re: [PATCH] net/bridge: use the maximum hard_header_len of ports for
	bridging device
Date: Wed, 25 Mar 2009 16:38:38 +0800
Message-ID: <2a27d3730903250138p447fcc17t33af99c709a29e13@mail.gmail.com>
References: <1237539869-30721-1-git-send-email-leoli@freescale.com>
	 <20090324.234051.60226102.davem@davemloft.net>
	 <2a27d3730903250005w2e773b01x1e9ec0606fc0e3d4@mail.gmail.com>
	 <20090325.000643.55804624.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: shemminger@linux-foundation.org, bridge@lists.linux-foundation.org,
	netdev@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from wf-out-1314.google.com ([209.85.200.175]:63011 "EHLO
	wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751708AbZCYIil convert rfc822-to-8bit (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 25 Mar 2009 04:38:41 -0400
Received: by wf-out-1314.google.com with SMTP id 29so3927677wff.4
        for <netdev@vger.kernel.org>; Wed, 25 Mar 2009 01:38:38 -0700 (PDT)
In-Reply-To: <20090325.000643.55804624.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Mar 25, 2009 at 3:06 PM, David Miller <davem@davemloft.net> wro=
te:
> From: Li Yang <leoli@freescale.com>
> Date: Wed, 25 Mar 2009 15:05:20 +0800
>
>> On Wed, Mar 25, 2009 at 2:40 PM, David Miller <davem@davemloft.net> =
wrote:
>> > From: Li Yang <leoli@freescale.com>
>> > Date: Fri, 20 Mar 2009 17:04:29 +0800
>> >
>> >> The bridging device used a constant hard_header_len. =C2=A0This w=
ill cause
>> >> headroom shortage for ports with additional hardware header. =C2=A0=
The patch
>> >> makes bridging device to use the maximum value of all ports.
>> >>
>> >> Signed-off-by: Li Yang <leoli@freescale.com>
>> >
>> > Your driver must be able to cope with any amount of
>> > available headroom, no matter what hacks we put into
>> > the bridging layer.
>> >
>> > Please fix your driver, I'm not applying this patch.
>>
>> Ok. =C2=A0But it's not good to reallocate every packet generated loc=
ally.
>> Why not take this patch too?
>
> Because as Stephen showed it didn't handle all cases.
>
> Look at the patch I posted, that's the way to go.

Patch coming right away.  However I have some comment about your way.
The choice is yours.

- Leo