From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christoph Paasch <cpaasch@apple.com>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
Tyler Hicks <tyhicks@canonical.com>
Subject: Re: [PATCH v2 net] net: Prevent invalid access to skb->prev in __qdisc_drop_all
Date: Thu, 29 Nov 2018 16:18:49 -0800 [thread overview]
Message-ID: <2a2a645c-edc7-a492-f218-10ac22bdb590@gmail.com> (raw)
In-Reply-To: <20181130000104.13213-1-cpaasch@apple.com>
On 11/29/2018 04:01 PM, Christoph Paasch wrote:
> __qdisc_drop_all() accesses skb->prev to get to the tail of the
> segment-list.
>
> With commit 68d2f84a1368 ("net: gro: properly remove skb from list")
> the skb-list handling has been changed to set skb->next to NULL and set
> the list-poison on skb->prev.
>
> With that change, __qdisc_drop_all() will panic when it tries to
> dereference skb->prev.
>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks !
next prev parent reply other threads:[~2018-11-30 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 0:01 [PATCH v2 net] net: Prevent invalid access to skb->prev in __qdisc_drop_all Christoph Paasch
2018-11-30 0:18 ` Eric Dumazet [this message]
2018-11-30 0:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2a645c-edc7-a492-f218-10ac22bdb590@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox