From: Heiner Kallweit <hkallweit1@gmail.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: "David Miller" <davem@davemloft.net>,
"Realtek linux nic maintainers" <nic_swsd@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Tony Atkinson" <tatkinson@linux.com>,
"David Arendt" <admin@prnet.org>, "Ortwin Glück" <odi@odi.ch>
Subject: Re: [net] r8169: fix network stalls due to missing bit TXCFG_AUTO_FIFO
Date: Fri, 28 Sep 2018 23:52:38 +0200 [thread overview]
Message-ID: <2a2aae48-17dc-04d2-69f3-c7bf96d5d378@gmail.com> (raw)
In-Reply-To: <7c59d5a8-44b6-3cf5-3321-7201f67305c8@maciej.szmigiero.name>
On 28.09.2018 23:47, Maciej S. Szmigiero wrote:
> On 28.09.2018 22:19, Heiner Kallweit wrote:
>> Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
>> in register TxConfig. The original patch changed the order of some
>> calls resulting in these changes being overwritten by
>> rtl_set_tx_config_registers() in rtl_hw_start(). This eventually
>> resulted in network stalls especially under high load.
>>
>> Analyzing the chip-specific hw_start functions all chip version from
>> 34, with the exception of version 39, need this bit set.
>> This patch moves setting this bit to rtl_set_tx_config_registers().
>>
>> Fixes: 4fd48c4ac0a0 ("r8169: move common initializations to tp->hw_start")
>> Reported-by: Ortwin Glück <odi@odi.ch>
>> Reported-by: David Arendt <admin@prnet.org>
>> Tested-by: Tony Atkinson <tatkinson@linux.com>
>> Tested-by: David Arendt <admin@prnet.org>
>> Tested-by: Ortwin Glück <odi@odi.ch>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Please add:
> Root-caused-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
>
Sure, forgot you in the list.
Heiner
> Thanks,
> Maciej
>
prev parent reply other threads:[~2018-09-29 4:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 20:19 [PATCH net] r8169: fix network stalls due to missing bit TXCFG_AUTO_FIFO Heiner Kallweit
2018-09-28 21:47 ` [net] " Maciej S. Szmigiero
2018-09-28 21:52 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2aae48-17dc-04d2-69f3-c7bf96d5d378@gmail.com \
--to=hkallweit1@gmail.com \
--cc=admin@prnet.org \
--cc=davem@davemloft.net \
--cc=mail@maciej.szmigiero.name \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=odi@odi.ch \
--cc=tatkinson@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).