From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [net] r8169: fix network stalls due to missing bit
 TXCFG_AUTO_FIFO
Date: Fri, 28 Sep 2018 23:52:38 +0200
Message-ID: <2a2aae48-17dc-04d2-69f3-c7bf96d5d378@gmail.com>
References: <141198ba-36e5-ba5c-e96a-8d4c08f810db@gmail.com>
 <7c59d5a8-44b6-3cf5-3321-7201f67305c8@maciej.szmigiero.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: David Miller <davem@davemloft.net>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Tony Atkinson <tatkinson@linux.com>,
        David Arendt <admin@prnet.org>,
        =?UTF-8?Q?Ortwin_Gl=c3=bcck?= <odi@odi.ch>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f67.google.com ([209.85.128.67]:51271 "EHLO
        mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726330AbeI2ESY (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 29 Sep 2018 00:18:24 -0400
Received: by mail-wm1-f67.google.com with SMTP id y25-v6so3537939wmi.1
        for <netdev@vger.kernel.org>; Fri, 28 Sep 2018 14:52:42 -0700 (PDT)
In-Reply-To: <7c59d5a8-44b6-3cf5-3321-7201f67305c8@maciej.szmigiero.name>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 28.09.2018 23:47, Maciej S. Szmigiero wrote:
> On 28.09.2018 22:19, Heiner Kallweit wrote:
>> Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
>> in register TxConfig. The original patch changed the order of some
>> calls resulting in these changes being overwritten by
>> rtl_set_tx_config_registers() in rtl_hw_start(). This eventually
>> resulted in network stalls especially under high load.
>>
>> Analyzing the chip-specific hw_start functions all chip version from
>> 34, with the exception of version 39, need this bit set.
>> This patch moves setting this bit to rtl_set_tx_config_registers().
>>
>> Fixes: 4fd48c4ac0a0 ("r8169: move common initializations to tp->hw_start")
>> Reported-by: Ortwin Glück <odi@odi.ch>
>> Reported-by: David Arendt <admin@prnet.org>
>> Tested-by: Tony Atkinson <tatkinson@linux.com>
>> Tested-by: David Arendt <admin@prnet.org>
>> Tested-by: Ortwin Glück <odi@odi.ch>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> Please add:
> Root-caused-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> 
Sure, forgot you in the list.

Heiner

> Thanks,
> Maciej
>