From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9783C282C2 for ; Wed, 13 Feb 2019 19:10:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AC1E2146E for ; Wed, 13 Feb 2019 19:10:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SgR1haXL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391831AbfBMTKu (ORCPT ); Wed, 13 Feb 2019 14:10:50 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45016 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726389AbfBMTKt (ORCPT ); Wed, 13 Feb 2019 14:10:49 -0500 Received: by mail-wr1-f65.google.com with SMTP id v16so3755737wrn.11 for ; Wed, 13 Feb 2019 11:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=KuF4FxcO9S74jidSKfUAdjrS8D/+i6NCi2tjLWnr0bY=; b=SgR1haXLdzdpDy0/PrV8MR5GnuMmLOdQ2mx6+sSfj2iEdGc7O3tuEKi2NwXB+dnavq ZxhhVDa5kJwz0qG1LuLgl362VKuTzcTHaOdrNRKhA72UsjeaagnpuJtp1q0aRxCMeZn8 Bb4ID4CSf+cJtnN34m3ncGXXnygb9GUvMyOACQfESJPL1AVtc2L4aQvLILXSJkYLyOTD BaD/n4UGt+QxlFbj0GnCJ5e+5tDZikrAZCfC3z0jDL6GVK0XwwyDs36x2zt5Q1xII+r2 bIt+Uk7JTPZyCIInqy9YwFqfQaKTCDHdFB3uLn53fJsGfKGNHpL82bA0xhlxiD3xLQC+ h6lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=KuF4FxcO9S74jidSKfUAdjrS8D/+i6NCi2tjLWnr0bY=; b=Nu9p00cX9cNNrkoiBDDdfXgGVwSyjiao3UD83d75HnAmiCiHU3VZIZea9iV6DhnjYx LBc3xPGmtEwKBALBz29mZIFHoUT3pzQHLZaloIAaQfsD9Ahy9Kgf5oaxPHpyH37VSD25 6QAO4UsE/k8S2mcXHWOgdJrRts3XJMrIwjH/DhbLShMq4iiNkK9Odj1t1Ai4CvQzO0Gf efaYMileO3owsN18jO8v2sxDeGG2QnYoD7D7vrQx7cNNoQ0xQCg8o2RKRn0dJIEf49Mv hTo0ctxZRp35wSeHGsW3S+3arYQPKU0Eb8Yu0KsLWb7L9wlI6cpWzWqWWS/CSsAPAiqX ekpA== X-Gm-Message-State: AHQUAuZh1/h7BckIpzdzUyB+iujGfrz9nmE+D4baqRDwfNUW7A/OBJIm nkpf85hbKmnaNEGvJN+W1GfW/dNL X-Google-Smtp-Source: AHgI3IZ5dq0wNekhJH4Mz/qij549krFnY/LDrGM4knxqoafxAKMqwSTMTxx/MZKAXocPeqO/42bVqg== X-Received: by 2002:adf:fa0d:: with SMTP id m13mr1555153wrr.93.1550085047820; Wed, 13 Feb 2019 11:10:47 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:a96a:7a3b:9f9b:531c? (p200300EA8BF1E200A96A7A3B9F9B531C.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:a96a:7a3b:9f9b:531c]) by smtp.googlemail.com with ESMTPSA id f196sm71919wme.36.2019.02.13.11.10.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 11:10:46 -0800 (PST) To: Andrew Lunn , Florian Fainelli , David Miller Cc: Russell King - ARM Linux , "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net 0/2] net: phy: fix locking issue Message-ID: <2a39271d-3b9e-e425-98b4-b2a24074e806@gmail.com> Date: Wed, 13 Feb 2019 20:10:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Russell pointed out that the locking used in phy_is_started() isn't needed and misleading. This locking also contributes to a race fixed with patch 2. Heiner Kallweit (2): net: phy: don't use locking in phy_is_started net: phy: fix potential race in the phylib state machine drivers/net/phy/phy.c | 13 +++++++------ include/linux/phy.h | 15 +-------------- 2 files changed, 8 insertions(+), 20 deletions(-) -- 2.20.1