From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Eric Dumazet <edumazet@google.com>
Cc: netdev <netdev@vger.kernel.org>, Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH iproute2] ss: add support for delivered and delivered_ce fields
Date: Wed, 28 Nov 2018 22:16:19 -0700 [thread overview]
Message-ID: <2a7b9fa6-b072-c45b-6e0e-8389eddc4576@gmail.com> (raw)
In-Reply-To: <35597e1d-3215-2157-7b00-b8c9bcfccb17@gmail.com>
On 11/28/18 10:10 PM, Eric Dumazet wrote:
>
>
> On 11/28/2018 04:01 PM, Stephen Hemminger wrote:
>> On Mon, 26 Nov 2018 14:29:53 -0800
>> Eric Dumazet <edumazet@google.com> wrote:
>>
>>> Kernel support was added in linux-4.18 in commit feb5f2ec6464
>>> ("tcp: export packets delivery info")
>>>
>>> Tested:
>>>
>>> ss -ti
>>> ...
>>> ESTAB 0 2270520 [2607:f8b0:8099:e16::]:47646 [2607:f8b0:8099:e18::]:38953
>>> ts sack cubic wscale:8,8 rto:7 rtt:2.824/0.278 mss:1428
>>> pmtu:1500 rcvmss:536 advmss:1428 cwnd:89 ssthresh:62 bytes_acked:2097871945
>>> segs_out:1469144 segs_in:65221 data_segs_out:1469142 send 360.0Mbps lastsnd:2
>>> lastrcv:99231 lastack:2 pacing_rate 431.9Mbps delivery_rate 246.4Mbps
>>> (*) delivered:1469099 delivered_ce:424799
>>> busy:99231ms unacked:44 rcv_space:14280 rcv_ssthresh:65535
>>> notsent:2207688 minrtt:0.228
>>>
>>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>>
>> Applied
>>
>
> Thanks Stephen
>
> BTW, it seems ss had some recent regression :
>
> Old ss command was happy with "ss dst 127.0.0.1 and not dst :12865"
>
> But current one is not.
>
> root@edumazet-glaptop:/usr/src/iproute2# ss -V
> ss utility, iproute2-ss171113
>
> root@edumazet-glaptop:/usr/src/iproute2# ss dst 127.0.0.1 and not dst :12865
> Netid State Recv-Q Send-Q Local Address:Port Peer Address:Port
> tcp ESTAB 0 0 127.0.0.1:45368 127.0.0.1:999
> tcp ESTAB 0 0 127.0.0.1:999 127.0.0.1:45368
>
>
> root@edumazet-glaptop:/usr/src/iproute2# misc/ss -V
> ss utility, iproute2-ss181023
>
> root@edumazet-glaptop:/usr/src/iproute2# misc/ss dst 127.0.0.1 and not dst :12865
> ss: bison bellows (while parsing filter): "syntax error!" Sorry.
> Usage: ss [ OPTIONS ]
> ss [ OPTIONS ] [ FILTER ]
> ...
>
Most logical commit to ssfilter.y is:
commit 38d209ecf2ae966b9b25de4acb60cdffb0e06ced
Author: Phil Sutter <phil@nwl.cc>
Date: Tue Aug 14 14:18:06 2018 +0200
ss: Review ssfilter
Can you revert it and see if it helps?
next prev parent reply other threads:[~2018-11-29 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 22:29 [PATCH iproute2] ss: add support for delivered and delivered_ce fields Eric Dumazet
2018-11-26 22:37 ` Yuchung Cheng
2018-11-29 0:01 ` Stephen Hemminger
2018-11-29 5:10 ` Eric Dumazet
2018-11-29 5:16 ` David Ahern [this message]
2018-11-29 5:25 ` Eric Dumazet
2018-11-29 12:20 ` [iproute PATCH] ssfilter: Fix for inverted last expression Phil Sutter
2018-11-30 18:22 ` Eric Dumazet
2018-12-03 22:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a7b9fa6-b072-c45b-6e0e-8389eddc4576@gmail.com \
--to=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox