From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2FC4C282C4 for ; Sat, 9 Feb 2019 08:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B714120869 for ; Sat, 9 Feb 2019 08:40:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aSKATwAe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbfBIIkz (ORCPT ); Sat, 9 Feb 2019 03:40:55 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37373 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726796AbfBIIkz (ORCPT ); Sat, 9 Feb 2019 03:40:55 -0500 Received: by mail-wm1-f67.google.com with SMTP id x10so1992628wmg.2 for ; Sat, 09 Feb 2019 00:40:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kqhmtfFdL3pxQwhbqvFdnO5GNhZhEFgT+vyaDczV5aw=; b=aSKATwAe/CSIR4tdlGDYFwRA/mmZQjU/ecgi/zDkHYQEH+91wuxhR3UKNBzKPkYmaf hPR4kZrsvKBqirsqlDm7gTBD0fWecptdGg6yAEwsgwKlS6ybfGxbITPQt+XRsuseXy0r Nsnvg0YN2kJZVcQSEyCxz3ll/xUwsMQ+PBpPdSORyjC3M5kX3o7bdCVMSso3LxaeoOpC ClQrhXg6WRBXSox4Txra+KbpzUBL1wNualTDIpwC6qqAm7wOk2mOtKFkwU0UnN/8vL+m /U6MAjRnxIuGARd7W3QFZ2O7UVa/sPAjhFIuOOXfuQAhYDmhJmv5kFCHUY31/6pxGHWZ mYMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kqhmtfFdL3pxQwhbqvFdnO5GNhZhEFgT+vyaDczV5aw=; b=H4bh1AbL8NPGWW9X4mDCGZtZozPxiNlrMecxNtx5e6lDEkXIYcyCBw3QGiOiTUlHUD 2NbfU4NfpgQ0N70paYeIbdilWO+twZZW7U13hTO2I1qR1v/JdP4T1zAgFje6OYhmOADP R1DTPL36sYjpiqFufDvt2U6YLKLzU2b1WiF81GKh1MV3m9EUxhjRAFfC6gTElzAnmTNQ lEE4yvYmM8L34Giqls4iRQ+j1yD+QBS8GLyvUei2vCXbc10hbEezFh1Yv1BW2jFbKmr3 vKQmadeoZ6NgQhoeh3Z+OisXVb2/eQ+Z2JdExsojxI4LWSwhMMZodJX4Kes+g6EwOqhN KIlQ== X-Gm-Message-State: AHQUAubFYjm/vtofCwl2JkYtA6liOSADg2g0aUcylgcrRglE8MnWozub lRW06A1iMHSq1UHmJYyFtQ4yzk69 X-Google-Smtp-Source: AHgI3IY113Iu73D74QS7h2IOgEkSqarOtOo6gSn78beWhzCph/AnDJMhWd83dkDGcQMG653Cr94mHQ== X-Received: by 2002:a1c:c441:: with SMTP id u62mr2216872wmf.69.1549701653063; Sat, 09 Feb 2019 00:40:53 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:aca4:3d:8205:4c97? (p200300EA8BF1E200ACA4003D82054C97.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:aca4:3d:8205:4c97]) by smtp.googlemail.com with ESMTPSA id s8sm8478817wrn.44.2019.02.09.00.40.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Feb 2019 00:40:52 -0800 (PST) Subject: Re: [PATCH v2 net-next] net: phy: disregard "Clause 22 registers present" bit in get_phy_c45_devs_in_pkg To: David Miller Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org References: <20190208.231100.2168035998559471182.davem@davemloft.net> From: Heiner Kallweit Message-ID: <2aa37780-7121-5c7f-3089-037ecaa1ad0c@gmail.com> Date: Sat, 9 Feb 2019 09:40:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190208.231100.2168035998559471182.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 09.02.2019 08:11, David Miller wrote: > From: Heiner Kallweit > Date: Fri, 8 Feb 2019 19:25:22 +0100 > >> Bit 0 in register 1.5 doesn't represent a device but is a flag that >> Clause 22 registers are present. Therefore disregard this bit when >> populating the device list. If code needs this information it >> should read register 1.5 directly instead of accessing the device >> list. >> Because this bit doesn't represent a device don't define a >> MDIO_MMD_XYZ constant, just define a MDIO_DEVS_XYZ constant for >> the flag in the device list bitmap. >> >> v2: >> - make masking of bit 0 more explicit >> - improve commit message >> Andrew had few further review comments and based on that I prepared a v3, this time as series of three patches. What you just applied was splitted to two patches and patch 1 is new. But this shouldn't be a big deal. We can keep what was applied and I will rebase patch 1 and resubmit it. >> Signed-off-by: Heiner Kallweit > > Applied, thanks Heiner. > Heiner