netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
	David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Phil Reid <preid@electromag.com.au>,
	jpinto <Joao.Pinto@synopsys.com>
Subject: Re: [PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt
Date: Thu, 2 Feb 2017 10:19:49 +0000	[thread overview]
Message-ID: <2aacf69b-a3f5-b16d-a38b-522ac00fbec9@synopsys.com> (raw)
In-Reply-To: <dc9df66b-022f-6a8b-8797-1965fc9b10bb@gmail.com>

Hi Heiner,

Às 7:20 AM de 2/2/2017, Heiner Kallweit escreveu:
> Most likely a copy & paste error in referenced commit.

Yep, thanks for noticing!

> Restore the debug message to what it was before.
> 
> Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - Don't remove the wrong comment but replace it with what
>   was there before the referenced commit.
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 460f94f5..4963ccdb 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -371,7 +371,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
>  	} else {
>  		clk_prepare_enable(plat->clk_ptp_ref);
>  		plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
> -		dev_info(&pdev->dev, "No reset control found\n");
> +		dev_dbg(&pdev->dev, "PTP rate %d\n", plat->clk_ptp_rate);
>  	}
>  
>  	plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
> 

Acked-By: Joao Pinto <jpinto@synopsys.com>

  reply	other threads:[~2017-02-02 10:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02  7:20 [PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt Heiner Kallweit
2017-02-02 10:19 ` Joao Pinto [this message]
2017-02-03  3:04 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2aacf69b-a3f5-b16d-a38b-522ac00fbec9@synopsys.com \
    --to=joao.pinto@synopsys.com \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=preid@electromag.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).