netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt
@ 2017-02-02  7:20 Heiner Kallweit
  2017-02-02 10:19 ` Joao Pinto
  2017-02-03  3:04 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2017-02-02  7:20 UTC (permalink / raw)
  To: David Miller; +Cc: netdev@vger.kernel.org, Phil Reid, jpinto

Most likely a copy & paste error in referenced commit.
Restore the debug message to what it was before.

Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- Don't remove the wrong comment but replace it with what
  was there before the referenced commit.
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 460f94f5..4963ccdb 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -371,7 +371,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
 	} else {
 		clk_prepare_enable(plat->clk_ptp_ref);
 		plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
-		dev_info(&pdev->dev, "No reset control found\n");
+		dev_dbg(&pdev->dev, "PTP rate %d\n", plat->clk_ptp_rate);
 	}
 
 	plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt
  2017-02-02  7:20 [PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt Heiner Kallweit
@ 2017-02-02 10:19 ` Joao Pinto
  2017-02-03  3:04 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Joao Pinto @ 2017-02-02 10:19 UTC (permalink / raw)
  To: Heiner Kallweit, David Miller; +Cc: netdev@vger.kernel.org, Phil Reid, jpinto

Hi Heiner,

Às 7:20 AM de 2/2/2017, Heiner Kallweit escreveu:
> Most likely a copy & paste error in referenced commit.

Yep, thanks for noticing!

> Restore the debug message to what it was before.
> 
> Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - Don't remove the wrong comment but replace it with what
>   was there before the referenced commit.
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 460f94f5..4963ccdb 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -371,7 +371,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
>  	} else {
>  		clk_prepare_enable(plat->clk_ptp_ref);
>  		plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
> -		dev_info(&pdev->dev, "No reset control found\n");
> +		dev_dbg(&pdev->dev, "PTP rate %d\n", plat->clk_ptp_rate);
>  	}
>  
>  	plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
> 

Acked-By: Joao Pinto <jpinto@synopsys.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt
  2017-02-02  7:20 [PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt Heiner Kallweit
  2017-02-02 10:19 ` Joao Pinto
@ 2017-02-03  3:04 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-03  3:04 UTC (permalink / raw)
  To: hkallweit1; +Cc: netdev, preid, Joao.Pinto

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 2 Feb 2017 08:20:12 +0100

> Most likely a copy & paste error in referenced commit.
> Restore the debug message to what it was before.
> 
> Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - Don't remove the wrong comment but replace it with what
>   was there before the referenced commit.

Applied to net-next.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-03  3:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-02  7:20 [PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt Heiner Kallweit
2017-02-02 10:19 ` Joao Pinto
2017-02-03  3:04 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).