Re: [PATCH net-next v2 00/12] Multiqueue + DSA untag support + fixes for mtk_eth_soc

Felix Fietkau
2022-11-10T19:03:54Z

Hi Russell,

On 10.11.22 19:50, Russell King (Oracle) wrote:
> Hi Felix,
>
> Not directly related to your patch series, but as you seem to be
> tinkering with the driver, it seems appropriate to ask. Are you
> using hardware that uses RGMII? If not, do you know anyone who is?
>
> It would be good to fix mtk_mac_config(), specifically the use
> of state->speed therein - see the FIXME that I placed in that
> function. Honestly, I think this code is broken, since if the
> RGMII interface speed changes, the outer if() won't allow this
> code path to be re-executed (since mac->interface will be the
> same as state->interface for speed changes.)
The only device I'm aware of which uses RGMII has the RGMII port
connected to a switch with no proper upstream driver support - no speed
changes expected there.

- Felix