From: "Andy Fleming" <afleming@gmail.com>
To: "Dave Jones" <davej@redhat.com>
Cc: "Dai Haruki" <dai.haruki@freescale.com>,
"Andy Fleming" <afleming@freescale.com>,
netdev@vger.kernel.org
Subject: Re: 2.6.28-git1 gianfar compile failure (ppc).
Date: Fri, 9 Jan 2009 12:10:38 -0600 [thread overview]
Message-ID: <2acbd3e40901091010r38d221b5nc2b2c98b589e55cb@mail.gmail.com> (raw)
In-Reply-To: <20081229054026.GA14962@redhat.com>
On Sun, Dec 28, 2008 at 11:41 PM, Dave Jones <davej@redhat.com> wrote:
> ERROR: "cacheable_memzero" [drivers/net/gianfar_driver.ko] undefined!
>
> Introduced in a22823e72a4821ce1d4a248fbd8f5a81795af339
>
> I guess that needs exporting for when gianfar is modular, but I've no
> idea how to export things from powerpc assembly.
>
> Dave
>
This patch which was posted to linuxppc-dev should fix your bug:
From: Kumar Gala <galak@kernel.crashing.org>
Date: Tue, Jan 6, 2009 at 11:00 PM
Subject: [PATCH] powerpc: Export cacheable_memzero as its now used in a driver
To: linuxppc-dev@ozlabs.org
The Freescale PowerPC specific gianfar driver (gig-e) uses
cacheable_memzero for performance reasons we need to export
the symbol to allow the driver to be built as a module.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
arch/powerpc/kernel/ppc_ksyms.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c
index dcec132..c8b27bb 100644
--- a/arch/powerpc/kernel/ppc_ksyms.c
+++ b/arch/powerpc/kernel/ppc_ksyms.c
@@ -165,6 +165,7 @@ EXPORT_SYMBOL(timer_interrupt);
EXPORT_SYMBOL(irq_desc);
EXPORT_SYMBOL(tb_ticks_per_jiffy);
EXPORT_SYMBOL(cacheable_memcpy);
+EXPORT_SYMBOL(cacheable_memzero);
#endif
#ifdef CONFIG_PPC32
--
1.5.6.5
prev parent reply other threads:[~2009-01-09 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 5:41 2.6.28-git1 gianfar compile failure (ppc) Dave Jones
2009-01-09 18:10 ` Andy Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2acbd3e40901091010r38d221b5nc2b2c98b589e55cb@mail.gmail.com \
--to=afleming@gmail.com \
--cc=afleming@freescale.com \
--cc=dai.haruki@freescale.com \
--cc=davej@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).