netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Willem de Bruijn <willemb@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	David Ahern <dsahern@kernel.org>,
	Jason Xing <kerneljasonxing@gmail.com>,
	Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/4] Add option to provide OPT_ID value via cmsg
Date: Wed, 4 Sep 2024 23:50:37 +0100	[thread overview]
Message-ID: <2b0e208a-a986-46a2-bd58-6464ae8da7d4@linux.dev> (raw)
In-Reply-To: <66d8cb426bc39_163d93294e@willemb.c.googlers.com.notmuch>

On 04/09/2024 22:04, Willem de Bruijn wrote:
>>>
>>> Vadim Fedorenko (4):
>>>     net_tstamp: add SCM_TS_OPT_ID to provide OPT_ID in control message
>>>     net_tstamp: add SCM_TS_OPT_ID for TCP sockets
>>>     net_tstamp: add SCM_TS_OPT_ID for RAW sockets
>>>     selftests: txtimestamp: add SCM_TS_OPT_ID test
>>>
>> Oh, sorry for the mess, patches:
>>
>> [PATCH v3 2/3] selftests: txtimestamp: add SCM_TS_OPT_ID test
>> [PATCH v3 3/3] net_tstamp: add SCM_TS_OPT_ID for TCP sockets
>>
>> should be ignored.
>>
>> If it too messy I can resend the series.
> 
> The series looks good to me. The four patches listed in the cover
> letter summary.
> 
> Overall looks great.
> 
> Perhaps the test can now also test TCP and RAW with a fixed OPT_ID.

Sure, I'll add these tests. As well as changes to address comments for 
1/4 patch.

Thanks,
Vadim

      reply	other threads:[~2024-09-04 22:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 11:31 [PATCH net-next v3 0/4] Add option to provide OPT_ID value via cmsg Vadim Fedorenko
2024-09-04 11:31 ` [PATCH net-next v3 1/4] net_tstamp: add SCM_TS_OPT_ID to provide OPT_ID in control message Vadim Fedorenko
2024-09-04 13:56   ` Jason Xing
2024-09-04 14:01     ` Vadim Fedorenko
2024-09-04 20:54   ` Willem de Bruijn
2024-09-05 10:10     ` Vadim Fedorenko
2024-09-05 13:29       ` Willem de Bruijn
2024-09-05  8:24   ` Jason Xing
2024-09-05  8:34     ` Vadim Fedorenko
2024-09-05  8:49       ` Jason Xing
2024-09-06  9:22   ` kernel test robot
2024-09-06 12:58   ` kernel test robot
2024-09-04 11:31 ` [PATCH net-next v3 2/4] net_tstamp: add SCM_TS_OPT_ID for TCP sockets Vadim Fedorenko
2024-09-05 14:58   ` Vadim Fedorenko
2024-09-05 15:37     ` Jason Xing
2024-09-05 16:39     ` Willem de Bruijn
2024-09-06 12:20       ` Vadim Fedorenko
2024-09-06 15:25         ` Willem de Bruijn
2024-09-06 16:33           ` Willem de Bruijn
2024-09-06 17:27             ` Vadim Fedorenko
2024-09-06 23:50               ` Willem de Bruijn
2024-09-06 17:27           ` Vadim Fedorenko
2024-09-06 23:48             ` Willem de Bruijn
2024-09-07 21:55               ` Vadim Fedorenko
2024-09-08 19:19                 ` Willem de Bruijn
2024-09-08 19:55                   ` Vadim Fedorenko
2024-09-04 11:31 ` [PATCH net-next v3 3/4] net_tstamp: add SCM_TS_OPT_ID for RAW sockets Vadim Fedorenko
2024-09-04 11:31 ` [PATCH net-next v3 4/4] selftests: txtimestamp: add SCM_TS_OPT_ID test Vadim Fedorenko
2024-09-04 11:36 ` [PATCH net-next v3 0/4] Add option to provide OPT_ID value via cmsg Vadim Fedorenko
2024-09-04 21:04   ` Willem de Bruijn
2024-09-04 22:50     ` Vadim Fedorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b0e208a-a986-46a2-bd58-6464ae8da7d4@linux.dev \
    --to=vadim.fedorenko@linux.dev \
    --cc=dsahern@kernel.org \
    --cc=horms@kernel.org \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).