From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: KMSAN: uninit-value in __inet6_bind
Date: Fri, 14 Dec 2018 07:14:46 -0800
Message-ID: <2b0f7497-7842-e9c3-c7b0-1b2bf2d5ea59@gmail.com>
References: <0000000000001568af057cb456a8@google.com>
 <CACT4Y+ZtAP4AVX9nARw+3PEdFL_WX3r37TAPuy=zBdZkg-0pRg@mail.gmail.com>
 <CAM_iQpUZmbsEPAz9s1bDVHbm08+h4WE4mvoxitttDCsXMQvQ4g@mail.gmail.com>
 <DM5PR15MB15135725A063E5370876EBA69AA10@DM5PR15MB1513.namprd15.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "syzbot+c56449ed3652e6720f30@syzkaller.appspotmail.com"
        <syzbot+c56449ed3652e6720f30@syzkaller.appspotmail.com>,
        Ying Xue <ying.xue@windriver.com>,
        "tipc-discussion@lists.sourceforge.net"
        <tipc-discussion@lists.sourceforge.net>,
        David Miller <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        "syzkaller-bugs@googlegroups.com" <syzkaller-bugs@googlegroups.com>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
To: Jon Maloy <jon.maloy@ericsson.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <DM5PR15MB15135725A063E5370876EBA69AA10@DM5PR15MB1513.namprd15.prod.outlook.com>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org



On 12/14/2018 07:04 AM, Jon Maloy wrote:
> 
> 
>> -----Original Message-----
>> From: Cong Wang <xiyou.wangcong@gmail.com>
>> Sent: 12-Dec-18 01:17
>> To: Dmitry Vyukov <dvyukov@google.com>
>> Cc: syzbot+c56449ed3652e6720f30@syzkaller.appspotmail.com; Jon Maloy
>> <jon.maloy@ericsson.com>; Ying Xue <ying.xue@windriver.com>; tipc-
>> discussion@lists.sourceforge.net; David Miller <davem@davemloft.net>;
>> Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>; LKML <linux-
>> kernel@vger.kernel.org>; Linux Kernel Network Developers
>> <netdev@vger.kernel.org>; syzkaller-bugs@googlegroups.com; Hideaki
>> YOSHIFUJI <yoshfuji@linux-ipv6.org>
>> Subject: Re: KMSAN: uninit-value in __inet6_bind
>>
>> On Tue, Dec 11, 2018 at 1:04 AM Dmitry Vyukov <dvyukov@google.com>
>> wrote:
>>>
>>> On Tue, Dec 11, 2018 at 1:41 AM syzbot
>>> <syzbot+c56449ed3652e6720f30@syzkaller.appspotmail.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> syzbot found the following crash on:
>>>>
>>>> HEAD commit:    3f06bda61398 kmsan: remove excessive KMSAN
>> wrappers from a..
>>>> git tree:       https://github.com/google/kmsan.git/master
>>>> console output:
>>>> https://syzkaller.appspot.com/x/log.txt?x=13ca6b05400000
>>>> kernel config:
>>>> https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641
>>>> dashboard link:
>> https://syzkaller.appspot.com/bug?extid=c56449ed3652e6720f30
>>>> compiler:       clang version 8.0.0 (trunk 348261)
>>>>
>>>> Unfortunately, I don't have any reproducer for this crash yet.
>>>>
>>>> IMPORTANT: if you fix the bug, please add the following tag to the
>> commit:
>>>> Reported-by: syzbot+c56449ed3652e6720f30@syzkaller.appspotmail.com
>>>
>>> This looks like a bug in TIPC, +TIPC maintainers.
>>>
>>
>> It looks more like udp_sock_create6() doesn't initialize
>> udp6_addr.sin6_scope_id.
> 
> Unfortunately udp_sock_create6() has no way of knowing this value, because struct udp_port_cfg is missing a field sin6_scope_id.
> So this has to be fixed first by adding this field to the struct, and then setting it correctly in all current users.
> 

Do we reasons to believe values other than 0 are needed ?