From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB1CC282C7 for ; Sat, 26 Jan 2019 14:10:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF8982087E for ; Sat, 26 Jan 2019 14:09:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BJnUKl4/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbfAZOJ6 (ORCPT ); Sat, 26 Jan 2019 09:09:58 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35436 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbfAZOJ6 (ORCPT ); Sat, 26 Jan 2019 09:09:58 -0500 Received: by mail-wr1-f68.google.com with SMTP id 96so13142939wrb.2 for ; Sat, 26 Jan 2019 06:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FJQPGyhrQKPXvPN1RwV4PKoFEDcYDyELc2rQNzHnyqM=; b=BJnUKl4/zL0dIyXISaVdq+d7yp5iRhNDNGvDu9T2kUBPYPzFGnNT2r9zI5JQW8KLB6 GRorcgrb49JGiT8jDUnMe2GfOeyruPDSDzUpPVQye6u7Y06yBmkIlX1GCrYsBF3wev/b AnIFji7ikCpFnhslN+W8wdroajV9ai/6Lx10o77w6hs3r+tFmxAh8+OpJ55iTT7HZo0X dA4Fxk/8o7fqSIzEJc/kbW80nFHGmDQXfdWRegmsyfbD3rjtMWS1QoOSX2oxj3l/OheO XdTGIeI/FLbNmNXSsLqo4NIN1MAaWAn0IwLoldniek2C2X0rA8L6P3vY3zB//DMT5nnI 5WPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FJQPGyhrQKPXvPN1RwV4PKoFEDcYDyELc2rQNzHnyqM=; b=Jm4ngZuv0QhyGLgnCYaXzwjM5/FSmL3zBI+VCVkwNhp8a3W0YKOINb8dSagzDJjFYX mQQRG6n6oIbmQ3iHogaBL7XWtpTzVgdaJThSe9CvYRgCNE64OlhLY58+VbXwJkpdM5lM 5czM5QxqHFXhckXD5vV2ccr6WTXGzPXM+MSnUtxXNQtyAYrq5aNbTMuxfNypkTcAoCSE YzkcmrR1z03xXGrPKNJ0791Qb/Qd/4SkRXVSJPEEtd/THDtU+YHoXeWQiOa+uhRUlgRL VPiAp6efB1OHwXQ3QHVKROZoW63QWSXlbNWumYMSYyQjol9OdxfZ628wysEKwQDM3+jf of4w== X-Gm-Message-State: AJcUukdixsMnL08zz0BwfIyuYwBDcw9EIc8zgN7+XKQK5nJPC+8KjmcZ lwI06CgCtzCfu1EKkdmBJTJT74gr X-Google-Smtp-Source: ALg8bN73HpRW29cQjBCGXQVGHgLhK7hOwWmG/JtM8Tv3Sp9/Sog66AKFnM7XEhz/Nfd9D/sTVKoK/A== X-Received: by 2002:adf:f211:: with SMTP id p17mr15089238wro.293.1548511795798; Sat, 26 Jan 2019 06:09:55 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:e416:5520:9c93:d4eb? (p200300EA8BF1E200E41655209C93D4EB.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:e416:5520:9c93:d4eb]) by smtp.googlemail.com with ESMTPSA id 124sm71942635wmh.22.2019.01.26.06.09.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Jan 2019 06:09:55 -0800 (PST) Subject: Re: WoL broken in r8169.c since kernel 4.19 From: Heiner Kallweit To: Marc Haber Cc: "netdev@vger.kernel.org" References: <20190112200831.GB20268@torres.zugschlus.de> <20190113160149.GG20268@torres.zugschlus.de> <47a81eb9-64bf-9477-f268-1fc35ee39cd9@gmail.com> Message-ID: <2b1f324a-8ace-f03c-b8d1-2358a5bb3a11@gmail.com> Date: Sat, 26 Jan 2019 15:09:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <47a81eb9-64bf-9477-f268-1fc35ee39cd9@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 26.01.2019 15:08, Heiner Kallweit wrote: > On 13.01.2019 17:01, Marc Haber wrote: >> On Sat, Jan 12, 2019 at 09:28:48PM +0100, Heiner Kallweit wrote: >>> On 12.01.2019 21:08, Marc Haber wrote: >>>> I am writing to all people who have commits in r8169.c between the v4.18 >>>> and v4.19 tags in the Linux kernel. Please ignore as appropriate. If >>>> you'd prefer that to be on a mailing list, please indicate on which list >>>> you want to have that, and I'll resend. >>>> >>> It should be cc'ed to the netdev mailing list, as listed in MAINTAINERS. >> >> I have bounced the original message there. Sorry for missing that, I was >> not aware that the MAINTAINERS file goes down on a single driver level. >> >>>> My desktop copmuter has the following network interface: >>>> >>>> 06:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 06) >>>> Subsystem: ASUSTeK Computer Inc. P8P67 and other motherboards >>>> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+ >>>> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- >>> Latency: 0, Cache Line Size: 64 bytes >>>> Interrupt: pin A routed to IRQ 17 >>>> NUMA node: 0 >>>> Region 0: I/O ports at e800 [size=256] >>>> Region 2: Memory at fdfff000 (64-bit, prefetchable) [size=4K] >>>> Region 4: Memory at fdff8000 (64-bit, prefetchable) [size=16K] >>>> Capabilities: >>>> Kernel driver in use: r8169 >>>> Kernel modules: r8169 >>>> >>> Unfortunately there's different chip versions with the same description. >>> Please provide the result of "dmesg | grep XID". >> >> [1/5004]mh@fan:~ $ dmesg | grep XID >> [ 2.671004] r8169 0000:06:00.0 eth0: RTL8168evl/8111evl, 54:04:a6:82:21:00, XID 2c900800, IRQ 29 >> >>>> I regularly buíld a VPN tunnel to my local network from 'on the road' >>>> and use WoL to wake up the desktop box when I need it. >>>> >>>> Since kernel 4.19, that does not work any more, the desktop remains >>>> suspended when I send it a magic packet. This still applies to 4.20.1, >>>> and it still works with any 4.18 kernel. >>>> >>> WoL works perfectly fine here with r8169 from runtime-suspend and >>> from S3. How do you enable WoL? And which WoL method do you use >>> (magic packet or ..) ? >> >> I do enable WOL via systemd-networkd: >> [7/5009]mh@fan:~ $ cat /etc/systemd/network/10-lanc0.link >> [Match] >> MACAddress=54:04:a6:82:21:00 >> >> [Link] >> Name=lanc0 >> WakeOnLan=magic >> >> and I wake up the box by calling >> >> sudo etherwake -i int182 54:04:a6:82:21:00 >> >> on the router. int182 is the interface name of the correct interface, >> this is proven correct by the fact that the box wakes up just fine with >> older version of the driver. >> >>> Please provide a register dump (ethtool -d ). >> >> The register dump is here (obtained with 4.20.1 with the r8169.c from >> 4.18): >> [5/5008]mh@fan:~ $ sudo ethtool -d lanc0 > > Just one more thing because this register dump was with the r8169 driver > from 4.18 which is known to work. > Can you provide a register dump from a 4.20 r8169 which suffers from the issue? > Sorry, just saw that you did so already.