From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [net-next v5 3/5] devlink: introduce flash update overwrite mask
Date: Fri, 11 Sep 2020 21:46:02 +0000 [thread overview]
Message-ID: <2b1f6ce3a6a14a47a116a017a89cfd13@intel.com> (raw)
In-Reply-To: <20200910183405.16bbfe34@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, September 10, 2020 6:34 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: netdev@vger.kernel.org
> Subject: Re: [net-next v5 3/5] devlink: introduce flash update overwrite mask
>
> On Thu, 10 Sep 2020 18:32:29 -0700 Jakub Kicinski wrote:
> > On Thu, 10 Sep 2020 14:28:10 -0700 Jacob Keller wrote:
> > > +#define DEVLINK_FLASH_OVERWRITE_SETTINGS
> BIT(DEVLINK_FLASH_OVERWRITE_SETTINGS_BIT)
> > > +#define DEVLINK_FLASH_OVERWRITE_IDENTIFIERS
> BIT(DEVLINK_FLASH_OVERWRITE_IDENTIFIERS_BIT)
> >
> > You got two more here.
>
> Ah! FWIW I found the macro you can use instead: _BITUL(x)
> Couldn't grep that one out yesterday.
Thanks, will fix
-Jake
next prev parent reply other threads:[~2020-09-11 21:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 21:28 [net-next v5 0/5] devlink flash update overwrite mask Jacob Keller
2020-09-10 21:28 ` [net-next v5 1/5] devlink: check flash_update parameter support in net core Jacob Keller
2020-09-10 21:28 ` [net-next v5 2/5] devlink: convert flash_update to use params structure Jacob Keller
2020-09-10 21:28 ` [net-next v5 3/5] devlink: introduce flash update overwrite mask Jacob Keller
2020-09-11 1:32 ` Jakub Kicinski
2020-09-11 1:34 ` Jakub Kicinski
2020-09-11 21:46 ` Keller, Jacob E [this message]
2020-09-10 21:28 ` [net-next v5 4/5] netdevsim: add support for flash_update " Jacob Keller
2020-09-10 21:28 ` [net-next v5 5/5] ice: add support for flash update " Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b1f6ce3a6a14a47a116a017a89cfd13@intel.com \
--to=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).