From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 0/5] macvlan offload fixes Date: Fri, 3 Nov 2017 10:13:11 -0700 Message-ID: <2b1fde7b-f590-336e-be4f-069f9e4ca954@oracle.com> References: <20171102232857.15146.21583.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Alexander Duyck , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:31756 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933753AbdKCRNO (ORCPT ); Fri, 3 Nov 2017 13:13:14 -0400 In-Reply-To: <20171102232857.15146.21583.stgit@localhost.localdomain> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/2/2017 4:33 PM, Alexander Duyck wrote: > I'm looking at performing a refactor of the macvlan offload code. However > before I started I wanted to at least get things into a running state. The > patches in this set are needed to address a number of issues that were > preventing things from working as they were supposed to. > > With these changes in place I seem to be able to receive traffic as I am > supposed to in the case of ixgbe and fm10k with the offload enabled, and I > am now transmitting to the correct Tx ring in the case of ixgbe. > > The last two patches in the set are what I consider to be minor clean-ups > to address the fact that we don't want packets to somehow stray and end up > being transmitted on a queue that is supposed to be in use by a macvlan > instead of the lowerdev itself. Other than the little misspelling I flagged, Acked-by: Shannon Nelson > > --- > > Alexander Duyck (5): > ixgbe: Fix interaction between SR-IOV and macvlan offload > fm10k: Fix VLAN configuration for macvlan offload > ixgbe: Fix handling of macvlan Tx offload > dev: Clean-up __skb_tx_hash to match up with traffic class based configs > dev: Cap number of queues even with accel_priv > > > drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 4 ++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 22 ++++++++++++++++++---- > net/core/dev.c | 21 ++++++++++----------- > 3 files changed, 30 insertions(+), 17 deletions(-) > > -- > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan >