From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, Shaohui.Xie@nxp.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: gianfar: add ethtool eee support
Date: Thu, 8 Dec 2016 15:22:19 -0800 [thread overview]
Message-ID: <2b309f6b-dcfd-006c-11ea-4fa2f35d01a5@gmail.com> (raw)
In-Reply-To: <20161208.181922.957507188752351548.davem@davemloft.net>
On 12/08/2016 03:19 PM, David Miller wrote:
> From: Shaohui Xie <Shaohui.Xie@nxp.com>
> Date: Thu, 8 Dec 2016 19:27:06 +0800
>
>> Gianfar does not support EEE, but it can connect to a PHY which supports
>> EEE and the PHY advertises EEE by default, and its link partner also
>> advertises EEE, so the PHY enters low power mode when traffic rate is low,
>> which causes packet loss if an application's traffic rate is low. This
>> patch provides .get_eee and .set_eee so that to disable the EEE
>> advertisement via ethtool if needed, other EEE features are not supported.
>>
>> Signed-off-by: Shaohui Xie <Shaohui.Xie@nxp.com>
>
> This is not the way to fix this.
>
> If the Gianfar MAC does not support EEE properly, then the gianfar
> driver should not create a situation where the PHY advertises EEE
> in the first place.
Agreed, you should have gianfar mask out the EEE advertisement from the
PHY it connects to, in order to make sure that EEE is properly disabled.
This should be no different from e.g: connecting a 10/100/1000 PHY to a
10/100 only controller for instance.
--
Florian
next prev parent reply other threads:[~2016-12-08 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:27 [PATCH] net: gianfar: add ethtool eee support Shaohui Xie
2016-12-08 23:19 ` David Miller
2016-12-08 23:22 ` Florian Fainelli [this message]
2016-12-09 2:55 ` S.H. Xie
-- strict thread matches above, loose matches on Subject: below --
2017-11-28 6:29 Yangbo Lu
2017-11-28 13:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b309f6b-dcfd-006c-11ea-4fa2f35d01a5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Shaohui.Xie@nxp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).