From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, dsahern@kernel.org
Cc: netdev@vger.kernel.org, weiwan@google.com, sd@queasysnail.net,
xiyou.wangcong@gmail.com, dsahern@gmail.com
Subject: Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6
Date: Fri, 5 Oct 2018 05:17:56 -0700 [thread overview]
Message-ID: <2b4d849f-9bd3-28aa-7a1c-ad61ab584041@gmail.com> (raw)
In-Reply-To: <20181004.215507.1973705600397352485.davem@davemloft.net>
On 10/04/2018 09:55 PM, David Miller wrote:
> From: David Ahern <dsahern@kernel.org>
> Date: Thu, 4 Oct 2018 20:07:50 -0700
>
>> From: David Ahern <dsahern@gmail.com>
>>
>> As part of the IPv6 fib info refactoring, the intent was to make metrics
>> handling for ipv6 identical to ipv4. One oversight in ip6_dst_destroy
>> led to confusion and a couple of incomplete attempts at finding and
>> fixing the resulting memory leak which was ultimately resolved by
>> ce7ea4af0838 ("ipv6: fix memory leak on dst->_metrics").
>>
>> Refactor metrics hanlding make the code really identical for v4 and v6,
>> and add a few test cases.
>
> Looks nice, series applied, thanks David.
>
Does not look well tested and reviewed to me.
next prev parent reply other threads:[~2018-10-05 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181005030755.31217-1-dsahern@kernel.org>
2018-10-05 4:55 ` [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6 David Miller
2018-10-05 12:17 ` Eric Dumazet [this message]
2018-10-05 13:08 ` Eric Dumazet
2018-10-05 15:37 ` David Ahern
2018-10-05 17:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b4d849f-9bd3-28aa-7a1c-ad61ab584041@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=weiwan@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).